python312Packages.pyscard: fix build

[itepastra]

this package got a build failure in 2bdb00d,
this was because swig got added to the required build-inputs.
Adding it to the nix build-inputs did not work so I made a replace which fixed it.

closes #352598

ZHF #352882

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[itepastra]

Hmm, now the yubikey-manager-qt package crashes seconds after starting. So there's probably something still wrong
Edit: the non qt version does seem to be stable, except that it doesn't recognize my yubikey when it's inserted

[Aleksanaa]

Adding it to the nix build-inputs did not work so I made a replace which fixed it.

Because you've not packaged https://pypi.org/project/swig/ ? Swig doesn't have python binding itself.

This is not a fix.

[itepastra]

I've packaged swig-pypi, the swig bindings for python and used that package for pyscard instead.
It looks like it uses swig correctly in the build now

[Aleksanaa]

@natsukium is it needed to keep attribute name the same with pypi name?

[NickCao]

Better fix in #353230, and upstream issue for yubikey-manager-qt: Yubico/yubikey-manager-qt#366

[natsukium]

is it needed to keep attribute name the same with pypi name?

Yes, the pypi name needs to be adopted and then normalized according to PEP503.

Attribute names in python-packages.nix as well as pnames should match the library's name on PyPI, but be normalized according to PEP 0503. This means that characters should be converted to lowercase and . and _ should be replaced by a single - (foo-bar-baz instead of Foo__Bar.baz). If necessary, pname has to be given a different value within fetchPypi.

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#contributing-guidelines-contributing-guidelines

[natsukium]

Regarding swig-pypi, if we want to package it, we should create our own stub like cmake/ninja.

[itepastra]

I will make a stub like cmake/ninja for swig if we want to, but this branch isn't needed anymore