installShellFiles: ensure shell completion has more than 256 bytes #247099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otavio
changed the title
ofborg
bot
requested review from
kalbasit,
amaxine,
babariviere,
Chili-Man,
marsam,
zimbatm,
zowoq,
techknowlogick and
timstott
|
Running nixpkgs-review to find other examples like terraform |
|
|
I found an error in the completion script of tmuxp which were outputting an error message instead of a proper script so a sanity check in the installShellCompletion script is helpful to avoid this to happen in the future. After looking at possible ways to detect this, the only valid check I found was based on the generated file size as any completion script I could find had more than 256 bytes. Signed-off-by: Otavio Salvador <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
otavio
force-pushed
the
avoid-too-small-shell-completions
branch
from
19d1eb9
to
32c275a
Compare
lucasew
suggested changes
Aug 5, 2023
|
can't nixpkgs-review it it's not going to fit |
12 tasks
|
Status? |
|
@Artturin it is ready, I'd need a full build log to fix any breakage of packages. |
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I found an error in the completion script of tmuxp which were outputting
an error message instead of a proper script so a sanity check in the
installShellCompletion script is helpful to avoid this to happen in the
future.
After looking at possible ways to detect this, the only valid check I
found was based on the generated file size as any completion script I
could find had more than 256 bytes.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)