utils/escape_attr: enclose with quotes all elements but the first + tests #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasew
force-pushed
the
fix-escape_attr
branch
from
a03a999
to
d9e8b49
Compare
Mic92
reviewed
Aug 6, 2023
Mic92
reviewed
Aug 6, 2023
Mic92
reviewed
Aug 6, 2023
Mic92
reviewed
Aug 6, 2023
Mic92
reviewed
Aug 6, 2023
…ests Signed-off-by: lucasew <[email protected]>
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 206889b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a lexing issue in nix when running nixpkgs-review for NixOS/nixpkgs#247099.
It generated a line like
haskelPackages.ifand Nix confused it with a if statement.I also added tests to check compliance.