utils/escape_attr: enclose with quotes all elements but the first + t…

…ests

Signed-off-by: lucasew <[email protected]>

nixpkgs_review/utils.py

@@ -39,10 +39,10 @@ def verify_commit_hash(commit: str) -> str:
 
 
 def escape_attr(attr: str) -> str:
-    index = attr.rfind(".")
-    if index == -1:
-        return attr
-    return f'{attr[:index]}."{attr[index+1:]}"'
+    attr_parts = attr.split('.')
+    first = attr_parts[0]
+    rest = [f'"{item}"' for item in attr_parts[1:]]
+    return ".".join([first, *rest])
 
 
 @functools.lru_cache(maxsize=1)

tests/test_escape_attr.py

@@ -0,0 +1,10 @@
+import pytest
+
+from nixpkgs_review.utils import escape_attr
+
+@pytest.mark.parametrize('test_input,expected', [
+    ('haskellPackages.if', 'haskellPackages."if"'),
+    ('haskellPackages.if.doc', 'haskellPackages."if"."doc"')
+])
+def test_escape_attr(test_input: str, expected: str) -> None:
+    assert escape_attr(test_input) == expected