Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turso-cli: Install shell completions #259090

Merged
merged 3 commits into from
Oct 5, 2023
Merged

turso-cli: Install shell completions #259090

merged 3 commits into from
Oct 5, 2023

Conversation

Fryuni
Copy link
Contributor

@Fryuni Fryuni commented Oct 5, 2023 •
edited
Loading

Description of changes

  • Added shell completions for turso-cli
  • Added myself as a maintainer
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kashw2 October 5, 2023 01:23
kashw2
kashw2 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@kashw2 kashw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great to have you helping maintain turso

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 5, 2023
@kashw2
Copy link
Contributor

kashw2 commented Oct 5, 2023

Result of nixpkgs-review pr 259090 run on x86_64-linux 1

1 package built:
  • turso-cli

@Artturin
Copy link
Member

Artturin commented Oct 5, 2023 •
edited
Loading

The log has

Error: unknown command "completions" for "turso"
Run 'turso --help' for usage.
Error: unknown command "completions" for "turso"
Run 'turso --help' for usage.
Error: unknown command "completions" for "turso"
Run 'turso --help' for usage.

and the files are empty

#247099 would catch issues like this

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 5, 2023
@ofborg ofborg bot requested a review from kashw2 October 5, 2023 11:29
@Artturin Artturin merged commit 35502f3 into NixOS:master Oct 5, 2023
10 checks passed
@Fryuni Fryuni deleted the turso branch October 6, 2023 12:07
@Fryuni
Copy link
Contributor Author

Fryuni commented Oct 6, 2023

Thanks for the help @wegank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Artturin left review comments

@kashw2 kashw2 Awaiting requested review from kashw2

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fryuni @kashw2 @Artturin @delroth @wegank