Remove restrictions in struct sort preventing calls to libcudf bounds #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
added
the
cudf_dependency
|
works as expected after removing relevant xfails SPARK_HOME=~/spark-3.1.1-bin-hadoop3.2 \
integration_tests/run_pyspark_from_build.sh -k test_single_nested_orderby
========= 20 passed, 5383 deselected, 100 xfailed in 188.11s (0:03:08) ========= |
|
Since rapidsai/cudf#7865 is targeting 0.20, this should target 0.6. |
gerashegalov
changed the title
gerashegalov
changed the title
|
build |
revans2
approved these changes
Apr 21, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…NVIDIA#2092) Signed-off-by: Gera Shegalov <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…NVIDIA#2092) Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gera Shegalov [email protected]
Closes #1605. In #1883 we had to work around the lack of struct support for
upper/lower_bound API in libcudf. This PR depends on rapidsai/cudf#7865