Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support sorting on struct type keys #1605

Closed
kuhushukla opened this issue Jan 27, 2021 · 1 comment · Fixed by #2092
Closed

[FEA] Support sorting on struct type keys #1605

kuhushukla opened this issue Jan 27, 2021 · 1 comment · Fixed by #2092
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@kuhushukla
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Once rapidsai/cudf#7226 is implemented we would want to test and add functionality to the plugin to be able to sort on nested type keys.
@kuhushukla kuhushukla added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jan 27, 2021
This was referenced Jan 27, 2021
Closed
Closed
@sameerz sameerz added cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed ? - Needs Triage Need team to review and classify labels Feb 2, 2021
@gerashegalov gerashegalov mentioned this issue Mar 5, 2021
Merged
gerashegalov added a commit that referenced this issue Mar 26, 2021
@gerashegalov
Enable sort for single-level nesting struct columns on GPU (#1883)
64f9d9b 
Adds single-level struct columns to sort. This PR contributes to #1605 

The following limitations apply with this PR for a total sort, and will be resolved in follow-up PR's
- only if the number of partitions is 1 
- only if spark.rapids.sql.stableSort.enabled is true
 
Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov mentioned this issue Apr 7, 2021
Merged
@sameerz sameerz closed this as completed Apr 21, 2021
@sameerz sameerz changed the title [FEA] Support sorting on nested type keys [FEA] Support sorting on struct type keys Apr 21, 2021
@sameerz
Copy link
Collaborator

sameerz commented Apr 21, 2021

The PR that closed this issue supports single level sorting on these data types: BOOLEAN + BYTE + SHORT + INT + LONG + FLOAT + DOUBLE + DATE + TIMESTAMP + STRING + NULL + DECIMAL

nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Enable sort for single-level nesting struct columns on GPU (NVIDIA#1883)
c49324c 
Adds single-level struct columns to sort. This PR contributes to NVIDIA#1605 

The following limitations apply with this PR for a total sort, and will be resolved in follow-up PR's
- only if the number of partitions is 1 
- only if spark.rapids.sql.stableSort.enabled is true
 
Signed-off-by: Gera Shegalov <[email protected]>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Enable sort for single-level nesting struct columns on GPU (NVIDIA#1883)
8e6762d 
Adds single-level struct columns to sort. This PR contributes to NVIDIA#1605 

The following limitations apply with this PR for a total sort, and will be resolved in follow-up PR's
- only if the number of partitions is 1 
- only if spark.rapids.sql.stableSort.enabled is true
 
Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove restrictions in struct sort preventing calls to libcudf bounds gerashegalov/spark-rapids
2 participants
@sameerz @kuhushukla