-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Struct binary search (lower_bound/upper_bound) #7865
Struct binary search (lower_bound/upper_bound) #7865
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7865 +/- ##
===============================================
+ Coverage 82.88% 82.91% +0.02%
===============================================
Files 103 103
Lines 17668 17655 -13
===============================================
- Hits 14645 14638 -7
+ Misses 3023 3017 -6
Continue to review full report at Codecov.
|
Rerun tests. |
tests in Spark are passing NVIDIA/spark-rapids#2092 (comment) |
@gpucibot merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake lgtm
This PR add support for
lower_bound
andupper_bound
binary searchs for structs column. This closes #7690.In addition to adding binary search for structs, I also did some refactoring for
tests/search/search_test.cpp
, extracting dictionary search test from it. As such, basic search tests, dictionary search tests and (the new) struct search tests are put in separate source files. This is easier to access and future maintainance.