Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue for contains when searching for an empty string #202

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fixed issue for contains when searching for an empty string #202

merged 1 commit into from
Jun 17, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jun 17, 2020

This fixes #121

@revans2 revans2 self-assigned this Jun 17, 2020
@revans2 revans2 added the bug Something isn't working label Jun 17, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Jun 17, 2020

build

@jlowe jlowe added this to the Jun 8 - Jun 19 milestone Jun 17, 2020
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only comment is if this is expected to be a short-term workaround for a bug in cudf it would be nice to place a comment in the code pointing at the cudf issue and saying this workaround could be replaced when that is fixed.

@revans2
Copy link
Collaborator Author

revans2 commented Jun 17, 2020

Turns out there is an un-needed check in the cudf java code that made us put in a work around. I will fix it in 0.15 for cudf and file something to have us fix it in the plugin after we go to 0.15

@revans2
Copy link
Collaborator Author

revans2 commented Jun 17, 2020

I filed #205 as a follow on issue

@revans2 revans2 merged commit 5cdc0d6 into NVIDIA:branch-0.1 Jun 17, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] contains of empty string on a null returns true
2 participants