Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] contains of empty string on a null returns true #121

Closed
revans2 opened this issue Jun 5, 2020 · 1 comment · Fixed by #202
Closed

[BUG] contains of empty string on a null returns true #121

revans2 opened this issue Jun 5, 2020 · 1 comment · Fixed by #202
Assignees
@revans2
Labels
bug Something isn't working SQL part of the SQL/Dataframe plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 5, 2020

Describe the bug
If we do a contains on a column looking for an empty string, if the column data is null a true is returned by the GPU but null is returned by the CPU

Steps/Code to reproduce bug
An integration test is being added for this.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels Jun 5, 2020
@revans2 revans2 removed the ? - Needs Triage Need team to review and classify label Jun 17, 2020
@revans2 revans2 self-assigned this Jun 17, 2020
@revans2 revans2 mentioned this issue Jun 17, 2020
Merged
@revans2
Copy link
Collaborator Author

revans2 commented Jun 18, 2020

rapidsai/cudf#5504 fixes this on the cudf side, along with similar issues for startsWith and endsWith all of these can have the special case for empty strings removed.

@revans2 revans2 mentioned this issue Jun 18, 2020
Closed
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@pxLi
Init cudf submodule for 22.06 (NVIDIA#121)
89c80c4 
Signed-off-by: Peixin Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed issue for contains when searching for an empty string
1 participant
@revans2