Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] clean up contains, startsWith and endsWith for cudf-0.15 #205

Closed
revans2 opened this issue Jun 17, 2020 · 1 comment · Fixed by #256
Closed

[BUG] clean up contains, startsWith and endsWith for cudf-0.15 #205

revans2 opened this issue Jun 17, 2020 · 1 comment · Fixed by #256
Assignees
@revans2
Labels
bug Something isn't working SQL part of the SQL/Dataframe plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 17, 2020

Describe the bug
the string contains function has special case code to handle an empty string. But the only reason it has this is because the cudf java API is doing an unneeded check on it. We should delete the check from the cudf java code and then delete the special case handling of empty strings here.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels Jun 17, 2020
@revans2 revans2 self-assigned this Jun 17, 2020
@revans2 revans2 mentioned this issue Jun 17, 2020
Merged
@kuhushukla
Copy link
Collaborator

kuhushukla commented Jun 17, 2020 •
edited
Loading

Agree we can remove this now given this is in which allows for it 4170d65 in cudf

@revans2 revans2 mentioned this issue Jun 18, 2020
Closed
@revans2 revans2 changed the title [BUG] clean up contains [BUG] clean up contains, startsWith and endsWith for cudf-0.15 Jun 18, 2020
@revans2 revans2 removed the ? - Needs Triage Need team to review and classify label Jun 22, 2020
@revans2 revans2 mentioned this issue Jun 22, 2020
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to dc1435b (NVIDIA#205)
d9a6b9a 
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove special cases for contains, startsWith, and endWith revans2/spark-rapids
2 participants
@revans2 @kuhushukla