Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Use ccache in build-in-docker #222

Closed
gerashegalov opened this issue May 4, 2022 · 0 comments · Fixed by #225 or #229
Closed

[FEA] Use ccache in build-in-docker #222

gerashegalov opened this issue May 4, 2022 · 0 comments · Fixed by #225 or #229
Assignees
Labels

Comments

@gerashegalov
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I wish RAPIDS Accelerator JNI for Apache Spark would be built with ccache support introduced in rapidsai/cudf#10790

Describe the solution you'd like
Provide an option or environment variable to easily turn on/off ccache via build-in-docker

Describe alternatives you've considered
A one-off personal script

Additional context
Sometimes one needs to remove the build directory to fix build issues. Always being able to clean build without taking a productivity hit prevents issues from occurring to begin with.

gerashegalov added a commit that referenced this issue May 6, 2022
This PR enables `ccache` in build-in-docker script by default, closes #222. 

A repeated no-change build with the native build dir cleaned is ~90 seconds
A repeated no-change build without removing the native build dir is ~30 seconds

The PR proposes to change the default to not skipping the clean of libcudf build unless CCACHE_DISABLE=1 is set.

Manual override of `libcudf.clean.skip` is honored.
 
Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov reopened this May 7, 2022
@gerashegalov gerashegalov self-assigned this May 9, 2022
gerashegalov added a commit that referenced this issue May 11, 2022
Reattempting reverted #225

This PR enables `ccache` in build-in-docker script by default, closes #222. 

A repeated no-change build with the native build dir cleaned is ~90 seconds
A repeated no-change build without removing the native build dir is ~30 seconds

The PR proposes to change the default to not skipping the clean of libcudf build unless CCACHE_DISABLE=1 is set.

Manual override of `libcudf.clean.skip` is honored.
 
Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant