Enable ccache for cudfjni build in Docker #10790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-in-docker-for-native
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
- and fix bug of CUDF_CPP_BUILD_DIR parameter being ignored Signed-off-by: Gera Shegalov <[email protected]>
…d-in-docker-for-native
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
added
3 - Ready for Review
gerashegalov
added
the
improvement
jlowe
reviewed
May 4, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10790 +/- ##
================================================
+ Coverage 86.40% 86.45% +0.04%
================================================
Files 143 143
Lines 22448 22491 +43
================================================
+ Hits 19396 19444 +48
+ Misses 3052 3047 -5
Continue to review full report at Codecov.
|
jlowe
reviewed
May 4, 2022
jlowe
approved these changes
May 4, 2022
Co-authored-by: Jason Lowe <[email protected]>
gerashegalov
added
the
5 - Ready to Merge
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables ccache support for
./build.sh clean cudfjar.ccache 4.6 is built during image creation because ccacheversion available via
yum installdoes not cache nvcc-compiled binaries.It's enabled by default for build.sh and repeated no-change build
PARALLEL_LEVEL=6 SKIP_TESTS=true time ./build.sh clean cudfjarsucceeds in 1.5 min on my machine. To disable set CCACHE_DISABLE=1 in the environment
It's not enabled for ./java/ci/build-in-docker.sh
Signed-off-by: Gera Shegalov [email protected]