Use ccache in build-in-docker by default #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
reviewed
May 6, 2022
Co-authored-by: Jason Lowe <[email protected]>
Co-authored-by: Jason Lowe <[email protected]>
jlowe
approved these changes
May 6, 2022
|
build |
gerashegalov
added a commit
that referenced
this pull request
May 6, 2022
This reverts commit 1a0689c.
pxLi
pushed a commit
that referenced
this pull request
May 7, 2022
* Revert "Use ccache in build-in-docker by default (#225)" This reverts commit 1a0689c. * signing the change Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
added a commit
that referenced
this pull request
May 11, 2022
Reattempting reverted #225 This PR enables `ccache` in build-in-docker script by default, closes #222. A repeated no-change build with the native build dir cleaned is ~90 seconds A repeated no-change build without removing the native build dir is ~30 seconds The PR proposes to change the default to not skipping the clean of libcudf build unless CCACHE_DISABLE=1 is set. Manual override of `libcudf.clean.skip` is honored. Signed-off-by: Gera Shegalov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
ccachein build-in-docker script by default, closes #222.A repeated no-change build with the native build dir cleaned is ~90 seconds
A repeated no-change build without removing the native build dir is ~30 seconds
The PR proposes to change the default to not skipping the clean of libcudf build unless CCACHE_DISABLE=1 is set.
Manual override of
libcudf.clean.skipis honored.Signed-off-by: Gera Shegalov [email protected]