Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1.2 bugfixes into main #2588

Merged
merged 16 commits into from
Jul 30, 2021
Merged

Merge 1.2 bugfixes into main #2588

merged 16 commits into from
Jul 30, 2021

Conversation

ericharper
Copy link
Collaborator

No description provided.

ericharper and others added 13 commits July 30, 2021 10:04
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Abhinav Khattar <[email protected]>
Signed-off-by: MaximumEntropy <[email protected]>
* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>
Signed-off-by: MaximumEntropy <[email protected]>
Signed-off-by: MaximumEntropy <[email protected]>
* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2021

This pull request fixes 1 alert when merging 3e404d8 into b5b29a6 - view on LGTM.com

fixed alerts:

  • 1 for Testing equality to None

Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
@ericharper ericharper requested a review from titu1994 July 30, 2021 16:33
@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2021

This pull request fixes 1 alert when merging 6a51af7 into b5b29a6 - view on LGTM.com

fixed alerts:

  • 1 for Testing equality to None

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericharper ericharper merged commit 4a7c3e3 into main Jul 30, 2021
@ericharper ericharper deleted the rebase_1.2_main branch July 30, 2021 17:53
blisc pushed a commit to blisc/NeMo that referenced this pull request Aug 12, 2021
* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update BRANCH

Signed-off-by: ericharper <[email protected]>

* Fix onnx for ASR notebook (NVIDIA#2542)

* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix typos and MeCab import (NVIDIA#2541)

Signed-off-by: MaximumEntropy <[email protected]>

* Fix branch for ASR notebooks (NVIDIA#2549)

Signed-off-by: smajumdar <[email protected]>

* rmtok (NVIDIA#2559)

Signed-off-by: Abhinav Khattar <[email protected]>

* Add xxhash dependency (NVIDIA#2564)

Signed-off-by: MaximumEntropy <[email protected]>

* fix (NVIDIA#2566)

* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>

* Fix moses path issue (NVIDIA#2573)

Signed-off-by: MaximumEntropy <[email protected]>

* More moses data path fixes (NVIDIA#2575)

Signed-off-by: MaximumEntropy <[email protected]>

* Path fixes (NVIDIA#2580)

Signed-off-by: MaximumEntropy <[email protected]>

* Upper bound transformers for 1.2 (NVIDIA#2584)

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Abhinav Khattar <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Signed-off-by: Jason <[email protected]>
paarthneekhara pushed a commit to paarthneekhara/NeMo that referenced this pull request Sep 17, 2021
* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update BRANCH

Signed-off-by: ericharper <[email protected]>

* Fix onnx for ASR notebook (NVIDIA#2542)

* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix typos and MeCab import (NVIDIA#2541)

Signed-off-by: MaximumEntropy <[email protected]>

* Fix branch for ASR notebooks (NVIDIA#2549)

Signed-off-by: smajumdar <[email protected]>

* rmtok (NVIDIA#2559)

Signed-off-by: Abhinav Khattar <[email protected]>

* Add xxhash dependency (NVIDIA#2564)

Signed-off-by: MaximumEntropy <[email protected]>

* fix (NVIDIA#2566)

* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>

* Fix moses path issue (NVIDIA#2573)

Signed-off-by: MaximumEntropy <[email protected]>

* More moses data path fixes (NVIDIA#2575)

Signed-off-by: MaximumEntropy <[email protected]>

* Path fixes (NVIDIA#2580)

Signed-off-by: MaximumEntropy <[email protected]>

* Upper bound transformers for 1.2 (NVIDIA#2584)

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Abhinav Khattar <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
jfsantos pushed a commit to jfsantos/NeMo that referenced this pull request Nov 19, 2021
* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update BRANCH

Signed-off-by: ericharper <[email protected]>

* Fix onnx for ASR notebook (NVIDIA#2542)

* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix typos and MeCab import (NVIDIA#2541)

Signed-off-by: MaximumEntropy <[email protected]>

* Fix branch for ASR notebooks (NVIDIA#2549)

Signed-off-by: smajumdar <[email protected]>

* rmtok (NVIDIA#2559)

Signed-off-by: Abhinav Khattar <[email protected]>

* Add xxhash dependency (NVIDIA#2564)

Signed-off-by: MaximumEntropy <[email protected]>

* fix (NVIDIA#2566)

* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>

* Fix moses path issue (NVIDIA#2573)

Signed-off-by: MaximumEntropy <[email protected]>

* More moses data path fixes (NVIDIA#2575)

Signed-off-by: MaximumEntropy <[email protected]>

* Path fixes (NVIDIA#2580)

Signed-off-by: MaximumEntropy <[email protected]>

* Upper bound transformers for 1.2 (NVIDIA#2584)

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Abhinav Khattar <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants