Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lang ID token for N-to-1 multilingual models #2559

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

aklife97
Copy link
Collaborator

Minor change that removes Lang ID token for N-to-1 multilingual models.

Signed-off-by: Abhinav Khattar <[email protected]>
Copy link
Member

@okuchaiev okuchaiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@okuchaiev okuchaiev merged commit 69d5a2c into r1.2.0 Jul 27, 2021
ericharper pushed a commit that referenced this pull request Jul 30, 2021
Signed-off-by: Abhinav Khattar <[email protected]>
ericharper added a commit that referenced this pull request Jul 30, 2021
* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update BRANCH

Signed-off-by: ericharper <[email protected]>

* Fix onnx for ASR notebook (#2542)

* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix typos and MeCab import (#2541)

Signed-off-by: MaximumEntropy <[email protected]>

* Fix branch for ASR notebooks (#2549)

Signed-off-by: smajumdar <[email protected]>

* rmtok (#2559)

Signed-off-by: Abhinav Khattar <[email protected]>

* Add xxhash dependency (#2564)

Signed-off-by: MaximumEntropy <[email protected]>

* fix (#2566)

* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>

* Fix moses path issue (#2573)

Signed-off-by: MaximumEntropy <[email protected]>

* More moses data path fixes (#2575)

Signed-off-by: MaximumEntropy <[email protected]>

* Path fixes (#2580)

Signed-off-by: MaximumEntropy <[email protected]>

* Upper bound transformers for 1.2 (#2584)

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Abhinav Khattar <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
blisc pushed a commit to blisc/NeMo that referenced this pull request Aug 12, 2021
* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update BRANCH

Signed-off-by: ericharper <[email protected]>

* Fix onnx for ASR notebook (NVIDIA#2542)

* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix typos and MeCab import (NVIDIA#2541)

Signed-off-by: MaximumEntropy <[email protected]>

* Fix branch for ASR notebooks (NVIDIA#2549)

Signed-off-by: smajumdar <[email protected]>

* rmtok (NVIDIA#2559)

Signed-off-by: Abhinav Khattar <[email protected]>

* Add xxhash dependency (NVIDIA#2564)

Signed-off-by: MaximumEntropy <[email protected]>

* fix (NVIDIA#2566)

* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>

* Fix moses path issue (NVIDIA#2573)

Signed-off-by: MaximumEntropy <[email protected]>

* More moses data path fixes (NVIDIA#2575)

Signed-off-by: MaximumEntropy <[email protected]>

* Path fixes (NVIDIA#2580)

Signed-off-by: MaximumEntropy <[email protected]>

* Upper bound transformers for 1.2 (NVIDIA#2584)

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Abhinav Khattar <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Signed-off-by: Jason <[email protected]>
paarthneekhara pushed a commit to paarthneekhara/NeMo that referenced this pull request Sep 17, 2021
* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update BRANCH

Signed-off-by: ericharper <[email protected]>

* Fix onnx for ASR notebook (NVIDIA#2542)

* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix typos and MeCab import (NVIDIA#2541)

Signed-off-by: MaximumEntropy <[email protected]>

* Fix branch for ASR notebooks (NVIDIA#2549)

Signed-off-by: smajumdar <[email protected]>

* rmtok (NVIDIA#2559)

Signed-off-by: Abhinav Khattar <[email protected]>

* Add xxhash dependency (NVIDIA#2564)

Signed-off-by: MaximumEntropy <[email protected]>

* fix (NVIDIA#2566)

* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>

* Fix moses path issue (NVIDIA#2573)

Signed-off-by: MaximumEntropy <[email protected]>

* More moses data path fixes (NVIDIA#2575)

Signed-off-by: MaximumEntropy <[email protected]>

* Path fixes (NVIDIA#2580)

Signed-off-by: MaximumEntropy <[email protected]>

* Upper bound transformers for 1.2 (NVIDIA#2584)

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Abhinav Khattar <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
jfsantos pushed a commit to jfsantos/NeMo that referenced this pull request Nov 19, 2021
* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update BRANCH

Signed-off-by: ericharper <[email protected]>

* Fix onnx for ASR notebook (NVIDIA#2542)

* Update onnx version

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix onnx

Signed-off-by: smajumdar <[email protected]>

* Fix typos and MeCab import (NVIDIA#2541)

Signed-off-by: MaximumEntropy <[email protected]>

* Fix branch for ASR notebooks (NVIDIA#2549)

Signed-off-by: smajumdar <[email protected]>

* rmtok (NVIDIA#2559)

Signed-off-by: Abhinav Khattar <[email protected]>

* Add xxhash dependency (NVIDIA#2564)

Signed-off-by: MaximumEntropy <[email protected]>

* fix (NVIDIA#2566)

* fix

Signed-off-by: nithinraok <[email protected]>

* doc add

Signed-off-by: nithinraok <[email protected]>

* style fix

Signed-off-by: nithinraok <[email protected]>

* Fix moses path issue (NVIDIA#2573)

Signed-off-by: MaximumEntropy <[email protected]>

* More moses data path fixes (NVIDIA#2575)

Signed-off-by: MaximumEntropy <[email protected]>

* Path fixes (NVIDIA#2580)

Signed-off-by: MaximumEntropy <[email protected]>

* Upper bound transformers for 1.2 (NVIDIA#2584)

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* upper bound transformers and name change jarvis to riva

Signed-off-by: ericharper <[email protected]>

* update jenkinsfile

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Abhinav Khattar <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
@blisc blisc deleted the rmtok1.2 branch January 11, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants