fix #2566
Merged
fix #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nithinraok <[email protected]>
tango4j
reviewed
Jul 28, 2021
tango4j
reviewed
Jul 28, 2021
Signed-off-by: nithinraok <[email protected]>
tango4j
previously approved these changes
Jul 28, 2021
Signed-off-by: nithinraok <[email protected]>
titu1994
previously approved these changes
Jul 28, 2021
| laplacian_torch = torch.from_numpy(Laplacian).float().to(device) | ||
| if TORCH_EIGN: | ||
| if cuda: | ||
| if device == None: |
There was a problem hiding this comment.
If device is None instead of == None
| if cuda: | ||
| if device == None: | ||
| device = torch.cuda.current_device() | ||
| Laplacian = torch.from_numpy(Laplacian).float().to(device) |
There was a problem hiding this comment.
Why capital Laplacian for a variable ? Lower case please
titu1994
approved these changes
Jul 28, 2021
|
This pull request fixes 1 alert when merging c005c67 into 7f7a499 - view on LGTM.com fixed alerts:
|
tango4j
reviewed
Jul 28, 2021
| @@ -120,7 +130,7 @@ def getCosAffinityMatrix(emb): | |||
|
|
|||
| def getLaplacian(X): | |||
| """ | |||
| Calculates a Laplacian matrix from an affinity matrix X. | |||
| Calculates a laplacian matrix from an affinity matrix X. | |||
There was a problem hiding this comment.
This better to be Laplacian while other variables are "laplacian"
tango4j
approved these changes
Jul 28, 2021
ericharper
pushed a commit
that referenced
this pull request
Jul 30, 2021
* fix Signed-off-by: nithinraok <[email protected]> * doc add Signed-off-by: nithinraok <[email protected]> * style fix Signed-off-by: nithinraok <[email protected]>
ericharper
added a commit
that referenced
this pull request
Jul 30, 2021
* update jenkinsfile Signed-off-by: ericharper <[email protected]> * update BRANCH Signed-off-by: ericharper <[email protected]> * Fix onnx for ASR notebook (#2542) * Update onnx version Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix typos and MeCab import (#2541) Signed-off-by: MaximumEntropy <[email protected]> * Fix branch for ASR notebooks (#2549) Signed-off-by: smajumdar <[email protected]> * rmtok (#2559) Signed-off-by: Abhinav Khattar <[email protected]> * Add xxhash dependency (#2564) Signed-off-by: MaximumEntropy <[email protected]> * fix (#2566) * fix Signed-off-by: nithinraok <[email protected]> * doc add Signed-off-by: nithinraok <[email protected]> * style fix Signed-off-by: nithinraok <[email protected]> * Fix moses path issue (#2573) Signed-off-by: MaximumEntropy <[email protected]> * More moses data path fixes (#2575) Signed-off-by: MaximumEntropy <[email protected]> * Path fixes (#2580) Signed-off-by: MaximumEntropy <[email protected]> * Upper bound transformers for 1.2 (#2584) * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * update jenkinsfile Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Abhinav Khattar <[email protected]> Co-authored-by: Nithin Rao <[email protected]>
blisc
pushed a commit
to blisc/NeMo
that referenced
this pull request
Aug 12, 2021
* update jenkinsfile Signed-off-by: ericharper <[email protected]> * update BRANCH Signed-off-by: ericharper <[email protected]> * Fix onnx for ASR notebook (NVIDIA#2542) * Update onnx version Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix typos and MeCab import (NVIDIA#2541) Signed-off-by: MaximumEntropy <[email protected]> * Fix branch for ASR notebooks (NVIDIA#2549) Signed-off-by: smajumdar <[email protected]> * rmtok (NVIDIA#2559) Signed-off-by: Abhinav Khattar <[email protected]> * Add xxhash dependency (NVIDIA#2564) Signed-off-by: MaximumEntropy <[email protected]> * fix (NVIDIA#2566) * fix Signed-off-by: nithinraok <[email protected]> * doc add Signed-off-by: nithinraok <[email protected]> * style fix Signed-off-by: nithinraok <[email protected]> * Fix moses path issue (NVIDIA#2573) Signed-off-by: MaximumEntropy <[email protected]> * More moses data path fixes (NVIDIA#2575) Signed-off-by: MaximumEntropy <[email protected]> * Path fixes (NVIDIA#2580) Signed-off-by: MaximumEntropy <[email protected]> * Upper bound transformers for 1.2 (NVIDIA#2584) * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * update jenkinsfile Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Abhinav Khattar <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Signed-off-by: Jason <[email protected]>
paarthneekhara
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Sep 17, 2021
* update jenkinsfile Signed-off-by: ericharper <[email protected]> * update BRANCH Signed-off-by: ericharper <[email protected]> * Fix onnx for ASR notebook (NVIDIA#2542) * Update onnx version Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix typos and MeCab import (NVIDIA#2541) Signed-off-by: MaximumEntropy <[email protected]> * Fix branch for ASR notebooks (NVIDIA#2549) Signed-off-by: smajumdar <[email protected]> * rmtok (NVIDIA#2559) Signed-off-by: Abhinav Khattar <[email protected]> * Add xxhash dependency (NVIDIA#2564) Signed-off-by: MaximumEntropy <[email protected]> * fix (NVIDIA#2566) * fix Signed-off-by: nithinraok <[email protected]> * doc add Signed-off-by: nithinraok <[email protected]> * style fix Signed-off-by: nithinraok <[email protected]> * Fix moses path issue (NVIDIA#2573) Signed-off-by: MaximumEntropy <[email protected]> * More moses data path fixes (NVIDIA#2575) Signed-off-by: MaximumEntropy <[email protected]> * Path fixes (NVIDIA#2580) Signed-off-by: MaximumEntropy <[email protected]> * Upper bound transformers for 1.2 (NVIDIA#2584) * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * update jenkinsfile Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Abhinav Khattar <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Signed-off-by: Paarth Neekhara <[email protected]>
jfsantos
pushed a commit
to jfsantos/NeMo
that referenced
this pull request
Nov 19, 2021
* update jenkinsfile Signed-off-by: ericharper <[email protected]> * update BRANCH Signed-off-by: ericharper <[email protected]> * Fix onnx for ASR notebook (NVIDIA#2542) * Update onnx version Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix onnx Signed-off-by: smajumdar <[email protected]> * Fix typos and MeCab import (NVIDIA#2541) Signed-off-by: MaximumEntropy <[email protected]> * Fix branch for ASR notebooks (NVIDIA#2549) Signed-off-by: smajumdar <[email protected]> * rmtok (NVIDIA#2559) Signed-off-by: Abhinav Khattar <[email protected]> * Add xxhash dependency (NVIDIA#2564) Signed-off-by: MaximumEntropy <[email protected]> * fix (NVIDIA#2566) * fix Signed-off-by: nithinraok <[email protected]> * doc add Signed-off-by: nithinraok <[email protected]> * style fix Signed-off-by: nithinraok <[email protected]> * Fix moses path issue (NVIDIA#2573) Signed-off-by: MaximumEntropy <[email protected]> * More moses data path fixes (NVIDIA#2575) Signed-off-by: MaximumEntropy <[email protected]> * Path fixes (NVIDIA#2580) Signed-off-by: MaximumEntropy <[email protected]> * Upper bound transformers for 1.2 (NVIDIA#2584) * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * upper bound transformers and name change jarvis to riva Signed-off-by: ericharper <[email protected]> * update jenkinsfile Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Abhinav Khattar <[email protected]> Co-authored-by: Nithin Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nithinraok [email protected]