Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ufs-release/public-v2: cherry-pick add GFSv16 dzmin change and changes for Dev/jcsda #63

Merged
merged 1 commit into from
Jan 12, 2021
Merged

ufs-release/public-v2: cherry-pick add GFSv16 dzmin change and changes for Dev/jcsda #63

merged 1 commit into from
Jan 12, 2021

Conversation

llpcarson
Copy link

@llpcarson llpcarson commented Jan 7, 2021 •
edited
Loading

  • add GFSv16 dzmin change
  • Add code changes in external_ic.F90 and fv_grid_tools.F90 for dev/jcsda

NOAA-EMC#44

Related PRs:
fv3atm: NOAA-EMC/fv3atm#223
ufs-weather-model: ufs-community/ufs-weather-model#356

@junwang-noaa
add GFSv16 dzmin change and changes for Dev/jcsda (#44)
abcda48 
* add GFSv16 dzmin change
* Add code changes in external_ic.F90 and fv_grid_tools.F90 for dev/jcsda, dycore PR #35

Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: Dan Holdaway <[email protected]>
This was referenced Jan 7, 2021
Merged
Merged
@junwang-noaa
Copy link
Collaborator

I am not sure why those changes are picked for release v2. My understanding is that the dzmin is a temporary fix for GFSv16, and the release v2 is for regional application, is there a stability issue in regional application? The two other code changes are for ongoing JEDI development, since more changes are coming and may be required for DA, I'd suggest people to go to dev/emc branch if they want to try DA application, rather than the release branch.

@climbfuji
Copy link

I am not sure why those changes are picked for release v2. My understanding is that the dzmin is a temporary fix for GFSv16, and the release v2 is for regional application, is there a stability issue in regional application? The two other code changes are for ongoing JEDI development, since more changes are coming and may be required for DA, I'd suggest people to go to dev/emc branch if they want to try DA application, rather than the release branch.

I think we need to ask @JeffBeck-NOAA and @jwolff-ncar, or at least they know whom to contact regarding the motivation for this PR.

@llpcarson
Copy link
Author

Hi Jun - Jacob Carley has been running his real-time parallel regional model with this change (dz_min) and finds the model is more stable. I cherry-picked the combined commit that included the jcsda changes, to simplify the git commit history. These are not required for the release branch, but were committed to develop together.

@jwolff-ncar
Copy link

This cherry-picked addition to the release branch was at the request of @JacobCarley-NOAA based on his experience with regional runs.

@bensonr
Copy link
Contributor

bensonr commented Jan 11, 2021

@junwang-noaa @laurenchilutti - can you guys provide a formal review.

@bensonr
Copy link
Contributor

bensonr commented Jan 11, 2021

If the reason for the updates is satisfactory to everyone, I can finish up the merge once I have formal reviews.

@lharris4
Copy link
Contributor

lharris4 commented Jan 11, 2021 via email

@lharris4
Copy link
Contributor

lharris4 commented Jan 11, 2021 via email

@lharris4
Copy link
Contributor

lharris4 commented Jan 11, 2021 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Jan 11, 2021 via email

@lharris4
Copy link
Contributor

lharris4 commented Jan 11, 2021 via email

@JacobCarley-NOAA
Copy link

Upon further review, the change to dz_min is fine but I have severe concerns about changing gz(km+1), which is the surface topography height. This does not change phis, the saved, static topography (to the best of my knowledge) but it could yield inconsistencies and noisy solutions. In particular when running at convective scales someone needs to check closely the behavior of w close to topography, especially steep marginally-resolved topography. Lucas On Mon, Jan 11, 2021 at 1:32 PM Lucas Harris - NOAA Federal < [email protected]> wrote:

Kate Zhou (@XiaqiongZhou-NOAA, [email protected]) may know more about this.

@XiaqiongZhou-NOAA
Copy link
Contributor

In the higher resolution regional runs, dz_min=6 is also a rare situation as in GFSv16.
This is a temporary fix for some crashes. This change actually prevents extreme large downdrafts and updrafts that finally cause model crashes even there are inconsistencies.

In addition, the regional group also found there were many extreme warm temperature warning in their runs as Kai-Yuan found. It can not be solved with the dz_min fix. They are related physics tendencies. It is a different issue that has to be investigated.

@climbfuji
Copy link

All, have we come to a conclusion about this PR for the SRW App release?

@junwang-noaa
Copy link
Collaborator

I'd refer to @JacobCarley-NOAA for approval as I am not sure if the changes are required to be included in public release-v2.

@JacobCarley-NOAA
Copy link

I'm good with this is those concerns expressed by @lharris4 were covered by comments from @XiaqiongZhou-NOAA .

junwang-noaa
junwang-noaa approved these changes Jan 12, 2021
View reviewed changes
Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jacob confirmed the code changes are required for release public_v2.

@lharris4
Copy link
Contributor

lharris4 commented Jan 12, 2021 via email

@llpcarson llpcarson mentioned this pull request Jan 12, 2021
Closed
@llpcarson
Copy link
Author

llpcarson commented Jan 12, 2021 via email

@lharris4
Copy link
Contributor

lharris4 commented Jan 12, 2021 via email

@bensonr bensonr merged commit 22c9326 into NOAA-GFDL:ufs-release/public-v2 Jan 12, 2021
@llpcarson llpcarson deleted the update_dz_min branch March 24, 2021 15:24
MicroTed pushed a commit to MicroTed/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2021
@climbfuji
Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land p…
34c326c 
…erturbations (NOAA-GFDL#239)

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch
* RUC ice for gsl/develop (replaces NOAA-GFDL#54 and NOAA-GFDL#56) (NOAA-GFDL#60) Implementation of RUC LSM ice model in CCPP
* Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge
* Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics
* Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml
* Update gsl/develop from develop 2020/12/08 (NOAA-GFDL#61)
* Fix for updating stochastic physics on separate time-step. (NOAA-GFDL#199)
This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.
* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (NOAA-GFDL#204)
* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
* Revert change to .gitmodules and update submodule pointer for ccpp-physics
* Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (NOAA-GFDL#63)
* Land stochastic perturbations (wrapper PR for NOAA-GFDL#65) (NOAA-GFDL#68)
* Move initialization of stochastic physics after the physics
initialization in CCPP.
* Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM.
* Max/min soil moisture variables are introduced via GFS_Control_type
variables instead of through the use of namelist_soilveg*. This is a
more flexible way for different LSMs.
* Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90.
* Remove tracer_sanitizer from all suites and from CCPP prebuild config
* Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90
* Stochastic land perturbations: add roughness length over land to the perturbed variables (NOAA-GFDL#70)
* Added roughness length over land to the perturbed variables.
* Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated
* Update .gitmodules and submodule pointer for GFDL_atmos_cubed_sphere for code review and testing
* Revert change to .gitmodules for ccpp-physics, update submodule pointer for ccpp-physics
* Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere
Co-authored-by: DomHeinzeller <[email protected]>
Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: tanyasmirnova <[email protected]>
binli2337 added a commit to binli2337/GFDL_atmos_cubed_sphere that referenced this pull request Dec 7, 2021
@binli2337
update external_ic.F90 and fv_nudge.F90 (NOAA-GFDL#63)
80d7c52
laurenchilutti pushed a commit to laurenchilutti/GFDL_atmos_cubed_sphere that referenced this pull request Jan 14, 2022
@binli2337 @laurenchilutti
update external_ic.F90 and fv_nudge.F90 (NOAA-GFDL#63)
81b9be0
laurenchilutti pushed a commit to laurenchilutti/GFDL_atmos_cubed_sphere that referenced this pull request Jan 20, 2022
@binli2337 @laurenchilutti
update external_ic.F90 and fv_nudge.F90 (NOAA-GFDL#63)
aa20e0a
laurenchilutti added a commit to laurenchilutti/GFDL_atmos_cubed_sphere that referenced this pull request Feb 18, 2022
@laurenchilutti
Revert "update external_ic.F90 and fv_nudge.F90 (NOAA-GFDL#63)"
abedccd 
This reverts commit 81b9be0.
laurenchilutti added a commit that referenced this pull request Feb 18, 2022
@laurenchilutti
Revertchanges (#177)
69d97bc 
* Revert "revise external_ic.F90 and fv_nudge.F90 (#68)"

This reverts commit 32b44d9.

* Revert "fixing call to pmaxmin to no longer get a compilation error when compiling with GNU."

This reverts commit 2aa049c.

* Revert "Update external_ic.F90 and fv_nudge.F90 to use allocatable arrays (#65)"

This reverts commit 44211c0.

* Revert "update external_ic.F90 and fv_nudge.F90 (#63)"

This reverts commit 81b9be0.

* Revert "Fix OVERLOAD_R4 ifdef block as suggested by @junwang-noaa (#60)"

This reverts commit 63a4603.

* Revert "Update code to use 'constantsR4_mod' module (#59)"

This reverts commit 7b8ee4c.
climbfuji pushed a commit to climbfuji/GFDL_atmos_cubed_sphere that referenced this pull request Apr 24, 2024
@mathomp4
Merge pull request NOAA-GFDL#63 from GEOS-ESM/feature/sdrabenh/v11.0.…
07d6493 
…0-rc.1_updates_v2

Additional updates for GCM v11.0.0-rc.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenchilutti laurenchilutti laurenchilutti approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@bensonr bensonr bensonr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@llpcarson @junwang-noaa @climbfuji @jwolff-ncar @bensonr @lharris4 @JacobCarley-NOAA @XiaqiongZhou-NOAA @laurenchilutti