Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grid_spec.nc file path in namelist more generic #32

Closed
CoryMartin-NOAA opened this issue Jul 20, 2020 · 1 comment
Closed

Make grid_spec.nc file path in namelist more generic #32

CoryMartin-NOAA opened this issue Jul 20, 2020 · 1 comment

Comments

@CoryMartin-NOAA
Copy link

The FV3 code has a namelist option to provide a "grid_spec" file which is useful for the regional applications as the grid doesn't have to be computed on the fly this way. However, the way the code is written, it has to be the file INPUT/grid_spec.nc, which means FV3-JEDI cannot regrid a regional grid to another regional grid (i.e. require two different grid spec files on two different paths, one original grid and one target grid).

These if statements in tools/fv_grid_tools.F90 should be modified so that GFDL_atmos_cubed_sphere can work for any grid_spec file specified in the input.nml and not require it to be either none or INPUT/grid_spec.nc.

I have already done this in JCSDA#2 but we eventually plan to use this fork for FV3-JEDI instead of a JCSDA fork.

I am open to comments or suggestions but my current solution is:
changing
else if( trim(grid_file) .NE. 'INPUT/grid_spec.nc') then
to be
else if( trim(grid_file) .EQ. 'Inline') then

Is this the correct way to make FV3 handle any generic value of grid_spec in the input.nml?

@danholdaway danholdaway mentioned this issue Sep 3, 2020
@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Jan 4, 2021

@CoryMartin-NOAA the code was committed in PR #35, can you close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants