Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufs-release/public-v2: merge HWRF updates, remove duplicate import of read_data from fms_mod #61

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Nov 12, 2020

This PR merges three small changes from a recent PR to dev/eemc into release/public-v2. One of them is for debugging, another for initializing model runs with less tracers than the physics requires, and yet another to remove a duplicate use statement (see issue NOAA-EMC#45).

Associated PRs:

NCAR/ccpp-physics#518
#61
NOAA-EMC/fv3atm#197
ufs-community/ufs-weather-model#276

For regression testing, see ufs-community/ufs-weather-model#276.

This PR contains two changes, one for avoiding crashes when the dycore debug option is turned on (in model/fv_dynamics.F90), and one for running microphysics with fewer tracers than in the input data set (in tools/external_ic.F90). This is required for Ferrier-Aligo microphysics.
@climbfuji climbfuji changed the title ufs-release/public-v2: merge HWRF updates ufs-release/public-v2: merge HWRF updates, remove duplicate import of read_data from fms_mod Nov 13, 2020
@climbfuji climbfuji marked this pull request as ready for review November 13, 2020 18:26
@climbfuji
Copy link
Author

@bensonr can you please take a look when you get a chance, or assign someone? These changes are all cherry picked from dev/emc for the upcoming SRW App release. Thanks very much in advance!

@climbfuji
Copy link
Author

All tests passed, this can be merged anytime.

@bensonr
Copy link
Contributor

bensonr commented Nov 17, 2020 via email

@bensonr bensonr merged commit 35079f0 into NOAA-GFDL:ufs-release/public-v2 Nov 17, 2020
@climbfuji
Copy link
Author

@climbfuji - will get this merged shortly.

Thanks very much, Rusty!

MicroTed pushed a commit to MicroTed/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2021
* add namelist variable iau_drymassfixer and use consistent coupled fields
* dump out coupled fields in native grid for fv3
* add default(none) for openmp in post_gfs.F90
* update fv3 dycore with reproduce option in g_sum
* change fv3 dycore to point to the NOAA-EMC dev/emc branch
MicroTed pushed a commit to MicroTed/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2021
…erturbations (NOAA-GFDL#239)

* Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for gsl/develop branch
* RUC ice for gsl/develop (replaces NOAA-GFDL#54 and NOAA-GFDL#56) (NOAA-GFDL#60) Implementation of RUC LSM ice model in CCPP
* Fix bug in gfsphysics/GFS_layer/GFS_typedefs.F90 from merge
* Remove lsm_ruc_sfc_sice from suite FV3_GSD_v0_unified_ugwp_suite and update submodule pointer for ccpp-physics
* Remove sfc_sice from ccpp/suites/suite_FV3_GSD_v0_unified_ugwp_suite.xml
* Update gsl/develop from develop 2020/12/08 (NOAA-GFDL#61)
* Fix for updating stochastic physics on separate time-step. (NOAA-GFDL#199)
This bug fix allows the random patterns in the stochastic physics persist the for a period of time (defined as SKEBINT,SPPTINT, etc.) before calculating new patterns.
The fix is to move the allocation of the saved variables into the init section of stochastic_physics_wrapper, and remove the deallocates in the run section.
* Bug fixes in (1) running with frac_grid=T and GFDL MP and (2) restarting with frac_grid=T (NOAA-GFDL#204)
* -- Pointing to Moorthi's modifications in ccpp/physics, which fixed the crash when running GFDL MP with frac_grid=T;
-- Not setting fice to zero in order to leave lake ice untouched;
-- Restart in the coupled model with the default physics is reproducible, if bad water temperature is only filtered at initial time;
Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
* Revert change to .gitmodules and update submodule pointer for ccpp-physics
* Update submodule pointer for ccpp-physics - MYNN surface layer updates and bugfixes (NOAA-GFDL#63)
* Land stochastic perturbations (wrapper PR for NOAA-GFDL#65) (NOAA-GFDL#68)
* Move initialization of stochastic physics after the physics
initialization in CCPP.
* Add albedo variables to land perturbations with lndp_type=2 option. Change to accommodate soil perturbations with RUC LSM.
* Max/min soil moisture variables are introduced via GFS_Control_type
variables instead of through the use of namelist_soilveg*. This is a
more flexible way for different LSMs.
* Added pores and resid variables for max/min soil moisture to GFS_typedefs.f90.
* Remove tracer_sanitizer from all suites and from CCPP prebuild config
* Add namelist option to apply land surface perturbations at every time step, clean up stochastic_physics/stochastic_physics_wrapper.F90
* Stochastic land perturbations: add roughness length over land to the perturbed variables (NOAA-GFDL#70)
* Added roughness length over land to the perturbed variables.
* Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90: remove Diag%cldcov, in particular the reset call because the variable is not allocated
* Update .gitmodules and submodule pointer for GFDL_atmos_cubed_sphere for code review and testing
* Revert change to .gitmodules for ccpp-physics, update submodule pointer for ccpp-physics
* Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere
Co-authored-by: DomHeinzeller <[email protected]>
Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: tanyasmirnova <[email protected]>
binli2337 pushed a commit to binli2337/GFDL_atmos_cubed_sphere that referenced this pull request Nov 12, 2021
climbfuji pushed a commit to climbfuji/GFDL_atmos_cubed_sphere that referenced this pull request Apr 24, 2024
…0-rc.1_updates

v11.0.0-rc.1 20230316 updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants