Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected two triggers #49

Conversation

ilianagenkova
Copy link
Contributor

Replaced:

  • obsproc_ver with obsproc_ver_pckg
  • obsproc with ${obsNET} in 2 triggers

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA merged commit 055b5d5 into release/obsproc.v1.0.0 Jun 22, 2022
@ilianagenkova ilianagenkova deleted the feature/rel.obsproc.v1.0.0_trigfix branch June 22, 2022 23:12
ilianagenkova added a commit that referenced this pull request Jun 22, 2022
* Incorporating changes made by NCO SPA following:
restart of cactus and
changing output data directory for mods

* Updated to correctly locate tcvitals file.

* Squashed commit of the following:

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

* Obsproc 'Module Load' order modifications (#39)

* Modified order of modules, specifically bufr-dump and prepobs.

* More shifts and changes.

* More adjustements, shifted added lines slightly, fixed bugs.

* Added in module unload phases.

* Added export before definition of envir.

* Including NCO changes for consideration to be incorporated into (#41)

release/obsproc.v1.0.0.

* Fixed a bug in JOBSPROC_AIRNOW_DUMP (#45)

Looks good. NCO will run test in para or test and then issue ARFC to be in place prior to go-live (6/28/2022)

* correct airnow processing when run by NCO (#48)

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Corrected two triggers (#49)

Co-authored-by: Shelley Melchior <[email protected]>
Co-authored-by: AshleyStanfield-NOAA <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 22, 2022
commit e741467
Merge: 055b5d5 e379362
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:14:55 2022 -0500

    Merge branch 'develop' into release/obsproc.v1.0.0

commit 055b5d5
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:10:59 2022 -0500

    Corrected two triggers (#49)

commit 6cc9cd7
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 22 19:10:05 2022 -0400

    correct airnow processing when run by NCO (#48)

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
ilianagenkova added a commit that referenced this pull request Jul 3, 2022
* Incorporating changes made by NCO SPA following:
restart of cactus and
changing output data directory for mods

* Updated to correctly locate tcvitals file.

* Squashed commit of the following:

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

* Obsproc 'Module Load' order modifications (#39)

* Modified order of modules, specifically bufr-dump and prepobs.

* More shifts and changes.

* More adjustements, shifted added lines slightly, fixed bugs.

* Added in module unload phases.

* Added export before definition of envir.

* Including NCO changes for consideration to be incorporated into (#41)

release/obsproc.v1.0.0.

* Fixed a bug in JOBSPROC_AIRNOW_DUMP (#45)

Looks good. NCO will run test in para or test and then issue ARFC to be in place prior to go-live (6/28/2022)

* correct airnow processing when run by NCO (#48)

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Corrected two triggers (#49)

* ecf change communicated by NCO

Co-authored-by: Shelley Melchior <[email protected]>
Co-authored-by: AshleyStanfield-NOAA <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ilianagenkova pushed a commit that referenced this pull request Jul 28, 2022
* Updated COMIN when JOBSPROC_AIRNOW_DUMP is run by non-NCO user to not
inherit previous definition for COMIN.

* Updated COMIN when JOBSPROC_AIRNOW_DUMP is run by non-NCO user to not
    inherit previous definition for COMIN.

* Squashed commit of the following:

commit e741467
Merge: 055b5d5 e379362
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:14:55 2022 -0500

    Merge branch 'develop' into release/obsproc.v1.0.0

commit 055b5d5
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:10:59 2022 -0500

    Corrected two triggers (#49)

commit 6cc9cd7
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 22 19:10:05 2022 -0400

    correct airnow processing when run by NCO (#48)

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants