Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: #19

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

ilianagenkova
Copy link
Contributor

The proposed changes speed up the JOBSPROC_*_PREP steps:
-use cfp and $NSPLIT with mpiexe command
-introduce
export FORT5=prepdata.stdin
-move ksh interpreter to top of MP_PREPDATA

Changes were tested with global and cdas networks

-use cfp with mpiexe -introduce FORT5 -move ksh interpreter
Copy link
Contributor

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check $HOMEobsproc to be sure you are using Jack Woollen's changes in your testing.

@@ -1744,6 +1744,7 @@ backup AFWA ACARS into PREPBUFR"

set +x
cat <<\EOFmpp > MP_PREPDATA
#!/bin/ksh
{ echo
#!/bin/ksh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the #!/bin/ksh at line 1749 does not need to be here; Jack's addition at 1747 is correct.

@@ -2114,7 +2117,8 @@ set -x
elif [ "$launcher_PREP" = mpiexec ]; then
chmod 755 $DATA/prep_exec.cmd
#mpiexec -n 6 -ppn 32 $DATA/prep_exec.cmd #IG
mpiexec -n 6 $DATA/prep_exec.cmd
# mpiexec -n 6 $DATA/prep_exec.cmd
mpiexec -n $NSPLIT cfp $DATA/prep_exec.cmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilianagenkova please check our test run. Your test run is not using this new code. Your $HOMEobsproc is set to /u/Iliana.Genkova/INSTALLpre/obsproc and the ush/prepobs_makeprepbufr.sh there does not have Jack's changes in it. Can you re-run and be sure you are running w/ his changes? For reference, I am looking in /lfs/h2/emc/ptmp/Iliana.Genkova/obsproc_gfs_prep_JWool_20210824_06.o9937950

Copy link
Contributor

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine; have been tested by 2 obsproc developers

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA merged commit bd4211a into develop Jan 4, 2022
@ShelleyMelchior-NOAA ShelleyMelchior-NOAA deleted the feature/develop_prep_fix branch January 4, 2022 01:23
ShelleyMelchior-NOAA added a commit that referenced this pull request Jan 4, 2022
commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
@ilianagenkova ilianagenkova restored the feature/develop_prep_fix branch January 6, 2022 22:58
@ShelleyMelchior-NOAA ShelleyMelchior-NOAA deleted the feature/develop_prep_fix branch March 25, 2022 15:23
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 2, 2022
commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 2, 2022
commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 7, 2022
commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 9, 2022
commit dd5ec6e
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 9 17:01:24 2022 +0000

    Added export before definition of envir.

commit 5609b1c
Author: AshleyStanfield-NOAA <[email protected]>
Date:   Wed Jun 8 21:52:00 2022 -0400

    Obsproc 'Module Load' order modifications (#39)

    * Modified order of modules, specifically bufr-dump and prepobs.

    * More shifts and changes.

    * More adjustements, shifted added lines slightly, fixed bugs.

    * Added in module unload phases.

commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods
KateFriedman-NOAA added a commit that referenced this pull request Jun 15, 2022
* Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)
* Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2
* Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT
* Added section to cd to logfile output dir prior to process submission.
* Squashed commit of the following:

commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods

Co-authored-by: iliana Genkova <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ilianagenkova added a commit that referenced this pull request Jun 22, 2022
* Incorporating changes made by NCO SPA following:
restart of cactus and
changing output data directory for mods

* Updated to correctly locate tcvitals file.

* Squashed commit of the following:

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

* Obsproc 'Module Load' order modifications (#39)

* Modified order of modules, specifically bufr-dump and prepobs.

* More shifts and changes.

* More adjustements, shifted added lines slightly, fixed bugs.

* Added in module unload phases.

* Added export before definition of envir.

* Including NCO changes for consideration to be incorporated into (#41)

release/obsproc.v1.0.0.

* Fixed a bug in JOBSPROC_AIRNOW_DUMP (#45)

Looks good. NCO will run test in para or test and then issue ARFC to be in place prior to go-live (6/28/2022)

* correct airnow processing when run by NCO (#48)

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Corrected two triggers (#49)

Co-authored-by: Shelley Melchior <[email protected]>
Co-authored-by: AshleyStanfield-NOAA <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 22, 2022
commit e741467
Merge: 055b5d5 e379362
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:14:55 2022 -0500

    Merge branch 'develop' into release/obsproc.v1.0.0

commit 055b5d5
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:10:59 2022 -0500

    Corrected two triggers (#49)

commit 6cc9cd7
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 22 19:10:05 2022 -0400

    correct airnow processing when run by NCO (#48)

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
ilianagenkova added a commit that referenced this pull request Jul 3, 2022
* Incorporating changes made by NCO SPA following:
restart of cactus and
changing output data directory for mods

* Updated to correctly locate tcvitals file.

* Squashed commit of the following:

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

* Obsproc 'Module Load' order modifications (#39)

* Modified order of modules, specifically bufr-dump and prepobs.

* More shifts and changes.

* More adjustements, shifted added lines slightly, fixed bugs.

* Added in module unload phases.

* Added export before definition of envir.

* Including NCO changes for consideration to be incorporated into (#41)

release/obsproc.v1.0.0.

* Fixed a bug in JOBSPROC_AIRNOW_DUMP (#45)

Looks good. NCO will run test in para or test and then issue ARFC to be in place prior to go-live (6/28/2022)

* correct airnow processing when run by NCO (#48)

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Corrected two triggers (#49)

* ecf change communicated by NCO

Co-authored-by: Shelley Melchior <[email protected]>
Co-authored-by: AshleyStanfield-NOAA <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ilianagenkova added a commit that referenced this pull request Jul 5, 2022
* Add override into cdate10 setting exglobal_makeprepbufr.sh (#37)

- allows entry for global-workflow to pass in cycle value when
outside of operational environment
- global-workflow config.prep will set cdate10 using $PDY$cyc
- tested and works on Orion

Refs: #34

* Develop sync and tcvitals bug fix updates for obsproc (#43)

* Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)
* Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2
* Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT
* Added section to cd to logfile output dir prior to process submission.
* Squashed commit of the following:

commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods

Co-authored-by: iliana Genkova <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>

* Update prepobs_ver to 1.0.1

Co-authored-by: iliana Genkova <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ilianagenkova pushed a commit that referenced this pull request Jul 28, 2022
* Updated COMIN when JOBSPROC_AIRNOW_DUMP is run by non-NCO user to not
inherit previous definition for COMIN.

* Updated COMIN when JOBSPROC_AIRNOW_DUMP is run by non-NCO user to not
    inherit previous definition for COMIN.

* Squashed commit of the following:

commit e741467
Merge: 055b5d5 e379362
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:14:55 2022 -0500

    Merge branch 'develop' into release/obsproc.v1.0.0

commit 055b5d5
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:10:59 2022 -0500

    Corrected two triggers (#49)

commit 6cc9cd7
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 22 19:10:05 2022 -0400

    correct airnow processing when run by NCO (#48)

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants