Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 #38

Merged
merged 2 commits into from
May 24, 2022
Merged

Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 #38

merged 2 commits into from
May 24, 2022

Conversation

ilianagenkova
Copy link
Contributor

Replaced obsproc_ver value in all triggers
Updated HOMEgfs in jglobal_prep trigger

@AshleyStanfield-NOAA , just look at the differences as a learning exercise in PR review, and approve PR if you think all looks ok.

@ShelleyMelchior-NOAA, this branch is off /develop b/c release has more changes and I instructed the team to work off develop.

@ilianagenkova ilianagenkova self-assigned this May 17, 2022
AshleyStanfield-NOAA
AshleyStanfield-NOAA previously approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@AshleyStanfield-NOAA AshleyStanfield-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great.

@ShelleyMelchior-NOAA
Copy link
Contributor

I might suggest we have two variables.
One needs to reflect all three digits, when referencing the software installation in $PACKAGEROOT. This could be $obsproc_ver.
One needs to reflect just the first two digits, when referencing data output in $COMROOT. This could be $obsproc_ver_com.

@ShelleyMelchior-NOAA
Copy link
Contributor

or maybe opposite ...
obsproc_ver can be the 2 digit variable.
obsproc_ver_install can be the 3 digit variable?

I just know there are times when we need to use both, at least in our triggers when we are using the NCO installed code vs a local installation.

@ilianagenkova
Copy link
Contributor Author

I don't object. Could we introduce obsproc_ver_pcg=v1.0.0 (package version)?
I don't remember if obsproc_ver is used across NCO, linked to Kate's stacks, etc. so we need to coordinate.

@ilianagenkova
Copy link
Contributor Author

Kate points to obsproc_ver in global-workflow's run.ver file.
Thus, I proposed we keep obsproc_ver=v1.0 as is.
I prefer we set obsproc_ver_pckg=v1.0.0 so one can be hinted at $PACKAGEROOT

@ShelleyMelchior-NOAA
Copy link
Contributor

I like it. Yes, keep obsproc_ver as is. Introduce obsproc_ver_pckg.

@AshleyStanfield-NOAA
Copy link
Contributor

Just to confirm, these changes to obsproc version number are only needed for jglobal prep triggers? No others are affected?

@ilianagenkova
Copy link
Contributor Author

@AshleyStanfield-NOAA, obsproc_ver is set in all triggers.
I already replaced obsproc_ver=v1.0.0 with obsproc_ver=v1.0 throughout them all, so the work is done.
@ShelleyMelchior-NOAA, shall I add obsproc_ver_pckg=v1.0.0 to all triggers as well? Even if it's not needed right now it isn't harming anyone.

@ShelleyMelchior-NOAA
Copy link
Contributor

Yes, go ahead and add $obsproc_ver_pckg to the triggers. This will be needed when one wishes to run NCO's installation of HOMEobsproc. The triggers should have that as a baseline option that gets commented out when one wants to point to a local installation of obsproc code.
Make this change and then update the PR.

@ShelleyMelchior-NOAA
Copy link
Contributor

So, for example, don't only add $obsproc_ver_pckg to the triggers, but also update each HOMEobsproc definition line that points to $PACKAGEROOT to use $obsproc_ver_pckg. Thanks!

@ilianagenkova
Copy link
Contributor Author

Introduced 3-digit version variable, obsproc_ver_pckg=v1.0.0, and added it to paths using PACKAGEROOT.

@ShelleyMelchior-NOAA
Copy link
Contributor

Just to confirm, these changes to obsproc version number are only needed for jglobal prep triggers? No others are affected?

@AshleyStanfield-NOAA this impacts all triggers since all could potentially reference the NCO installation of obsproc rather than a local installation of obsproc.

ShelleyMelchior-NOAA
ShelleyMelchior-NOAA approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for obsproc variables for both obsproc code installation (obsproc_ver_pckg) and obsproc data output in com (obsproc_ver) look as expected and discussed.

@ilianagenkova ilianagenkova merged commit 30c01f9 into develop May 24, 2022
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 2, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
21d7d9a 
commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 2, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
e379362 
commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 7, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
cbc15ed 
commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 9, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
625bf97 
commit dd5ec6e
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 9 17:01:24 2022 +0000

    Added export before definition of envir.

commit 5609b1c
Author: AshleyStanfield-NOAA <[email protected]>
Date:   Wed Jun 8 21:52:00 2022 -0400

    Obsproc 'Module Load' order modifications (#39)

    * Modified order of modules, specifically bufr-dump and prepobs.

    * More shifts and changes.

    * More adjustements, shifted added lines slightly, fixed bugs.

    * Added in module unload phases.

commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods
KateFriedman-NOAA added a commit that referenced this pull request Jun 15, 2022
@KateFriedman-NOAA @ilianagenkova @ShelleyMelchior-NOAA
Develop sync and tcvitals bug fix updates for obsproc (#43)
591ce2c 
* Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)
* Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2
* Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT
* Added section to cd to logfile output dir prior to process submission.
* Squashed commit of the following:

commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods

Co-authored-by: iliana Genkova <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ilianagenkova added a commit that referenced this pull request Jun 22, 2022
@ilianagenkova @ShelleyMelchior-NOAA @AshleyStanfield-NOAA
Release/obsproc.v1.0.0 (#46)
ba34054 
* Incorporating changes made by NCO SPA following:
restart of cactus and
changing output data directory for mods

* Updated to correctly locate tcvitals file.

* Squashed commit of the following:

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

* Obsproc 'Module Load' order modifications (#39)

* Modified order of modules, specifically bufr-dump and prepobs.

* More shifts and changes.

* More adjustements, shifted added lines slightly, fixed bugs.

* Added in module unload phases.

* Added export before definition of envir.

* Including NCO changes for consideration to be incorporated into (#41)

release/obsproc.v1.0.0.

* Fixed a bug in JOBSPROC_AIRNOW_DUMP (#45)

Looks good. NCO will run test in para or test and then issue ARFC to be in place prior to go-live (6/28/2022)

* correct airnow processing when run by NCO (#48)

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Corrected two triggers (#49)

Co-authored-by: Shelley Melchior <[email protected]>
Co-authored-by: AshleyStanfield-NOAA <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ShelleyMelchior-NOAA added a commit that referenced this pull request Jun 22, 2022
@ShelleyMelchior-NOAA
Squashed commit of the following:
ede4ea9 
commit e741467
Merge: 055b5d5 e379362
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:14:55 2022 -0500

    Merge branch 'develop' into release/obsproc.v1.0.0

commit 055b5d5
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:10:59 2022 -0500

    Corrected two triggers (#49)

commit 6cc9cd7
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 22 19:10:05 2022 -0400

    correct airnow processing when run by NCO (#48)

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
ilianagenkova added a commit that referenced this pull request Jul 3, 2022
@ilianagenkova @ShelleyMelchior-NOAA @AshleyStanfield-NOAA
Release/obsproc.v1.0.0 - final NCO teaks and /trigger changes (#50)
128ebc1 
* Incorporating changes made by NCO SPA following:
restart of cactus and
changing output data directory for mods

* Updated to correctly locate tcvitals file.

* Squashed commit of the following:

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

* Obsproc 'Module Load' order modifications (#39)

* Modified order of modules, specifically bufr-dump and prepobs.

* More shifts and changes.

* More adjustements, shifted added lines slightly, fixed bugs.

* Added in module unload phases.

* Added export before definition of envir.

* Including NCO changes for consideration to be incorporated into (#41)

release/obsproc.v1.0.0.

* Fixed a bug in JOBSPROC_AIRNOW_DUMP (#45)

Looks good. NCO will run test in para or test and then issue ARFC to be in place prior to go-live (6/28/2022)

* correct airnow processing when run by NCO (#48)

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

* Corrected two triggers (#49)

* ecf change communicated by NCO

Co-authored-by: Shelley Melchior <[email protected]>
Co-authored-by: AshleyStanfield-NOAA <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
KateFriedman-NOAA added a commit that referenced this pull request Jul 5, 2022
@KateFriedman-NOAA
Merge branch 'develop' into develop-rd
fb0d29e 
* develop:
  Release/obsproc.v1.0.0 - final NCO teaks and /trigger changes (#50)
  Release/obsproc.v1.0.0 (#46)
  Squashed commit of the following:
  Added section to cd to logfile output dir prior to process submission.
  Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)
ilianagenkova added a commit that referenced this pull request Jul 5, 2022
@KateFriedman-NOAA @ilianagenkova @ShelleyMelchior-NOAA
Merge R&D changes into obsproc develop (#52)
8399261 
* Add override into cdate10 setting exglobal_makeprepbufr.sh (#37)

- allows entry for global-workflow to pass in cycle value when
outside of operational environment
- global-workflow config.prep will set cdate10 using $PDY$cyc
- tested and works on Orion

Refs: #34

* Develop sync and tcvitals bug fix updates for obsproc (#43)

* Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)
* Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2
* Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT
* Added section to cd to logfile output dir prior to process submission.
* Squashed commit of the following:

commit 21d7d9a
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 13:30:52 2022 +0000

    Squashed commit of the following:

    commit daff5af
    Author: Shelley Melchior <[email protected]>
    Date:   Fri May 27 18:05:05 2022 +0000

        Added section to cd to logfile output dir prior to process submission.

    commit 30c01f9
    Author: iliana Genkova <[email protected]>
    Date:   Tue May 24 11:37:06 2022 -0500

        Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

        * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

        * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

    commit ebb6c68
    Author: Cory Martin <[email protected]>
    Date:   Tue Apr 12 15:15:47 2022 -0400

        Changes needed to build on Hera (#32)

    commit 0075564
    Author: Shelley Melchior <[email protected]>
    Date:   Sat Apr 9 17:07:10 2022 -0400

        Incorporating changes made by NCO SPA following: (#35)

        restart of cactus and
        changing output data directory for mods

    commit 59596a9
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Apr 7 21:27:40 2022 +0000

        Removing top level README.md. This file now resides in docs/.

    commit 735f009
    Merge: bd4211a 8f28c00
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:51:34 2022 +0000

        Merge branch 'release/obsproc.v1.0.0' into develop

    commit 8f28c00
    Merge: f01f691 bd4211a
    Author: Iliana Genkova <[email protected]>
    Date:   Thu Apr 7 20:49:01 2022 +0000

        Removed build.sh (now in /build-obsproc) and
        ush/prepobs_makeprepbufr.sh(now in module prepobs)
        Merge branch 'develop' into release/obsproc.v1.0.0

    commit bd4211a
    Author: iliana Genkova <[email protected]>
    Date:   Mon Jan 3 19:23:04 2022 -0600

        Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

        * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
        -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

        * Clean up interpreter

    commit 309371d
    Author: Shelley Melchior <[email protected]>
    Date:   Mon Jan 3 18:25:21 2022 -0500

        created README.md

        Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

    commit c5342eb
    Author: Rahul Mahajan <[email protected]>
    Date:   Mon Jan 3 17:57:29 2022 -0500

        adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

commit e63a78c
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 1 16:21:51 2022 +0000

    Updated to correctly locate tcvitals file.

commit 0bbb542
Author: Shelley Melchior <[email protected]>
Date:   Fri Apr 8 20:31:15 2022 +0000

    Incorporating changes made by NCO SPA following:
    restart of cactus and
    changing output data directory for mods

Co-authored-by: iliana Genkova <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>

* Update prepobs_ver to 1.0.1

Co-authored-by: iliana Genkova <[email protected]>
Co-authored-by: Shelley Melchior <[email protected]>
ilianagenkova pushed a commit that referenced this pull request Jul 28, 2022
@ShelleyMelchior-NOAA
Feature/airnow4devuser (#62)
c13958f 
* Updated COMIN when JOBSPROC_AIRNOW_DUMP is run by non-NCO user to not
inherit previous definition for COMIN.

* Updated COMIN when JOBSPROC_AIRNOW_DUMP is run by non-NCO user to not
    inherit previous definition for COMIN.

* Squashed commit of the following:

commit e741467
Merge: 055b5d5 e379362
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:14:55 2022 -0500

    Merge branch 'develop' into release/obsproc.v1.0.0

commit 055b5d5
Author: iliana Genkova <[email protected]>
Date:   Wed Jun 22 18:10:59 2022 -0500

    Corrected two triggers (#49)

commit 6cc9cd7
Author: Shelley Melchior <[email protected]>
Date:   Wed Jun 22 19:10:05 2022 -0400

    correct airnow processing when run by NCO (#48)

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

    * Updating JOBSPROC_AIRNOW_DUMP to work correctly when user is NCO.

commit e379362
Author: Shelley Melchior <[email protected]>
Date:   Thu Jun 2 14:38:13 2022 +0000

    Squashed commit of the following:

    commit 21d7d9a
    Author: Shelley Melchior <[email protected]>
    Date:   Thu Jun 2 13:30:52 2022 +0000

        Squashed commit of the following:

        commit daff5af
        Author: Shelley Melchior <[email protected]>
        Date:   Fri May 27 18:05:05 2022 +0000

            Added section to cd to logfile output dir prior to process submission.

        commit 30c01f9
        Author: iliana Genkova <[email protected]>
        Date:   Tue May 24 11:37:06 2022 -0500

            Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

            * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

            * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

        commit ebb6c68
        Author: Cory Martin <[email protected]>
        Date:   Tue Apr 12 15:15:47 2022 -0400

            Changes needed to build on Hera (#32)

        commit 0075564
        Author: Shelley Melchior <[email protected]>
        Date:   Sat Apr 9 17:07:10 2022 -0400

            Incorporating changes made by NCO SPA following: (#35)

            restart of cactus and
            changing output data directory for mods

        commit 59596a9
        Author: Shelley Melchior <[email protected]>
        Date:   Thu Apr 7 21:27:40 2022 +0000

            Removing top level README.md. This file now resides in docs/.

        commit 735f009
        Merge: bd4211a 8f28c00
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:51:34 2022 +0000

            Merge branch 'release/obsproc.v1.0.0' into develop

        commit 8f28c00
        Merge: f01f691 bd4211a
        Author: Iliana Genkova <[email protected]>
        Date:   Thu Apr 7 20:49:01 2022 +0000

            Removed build.sh (now in /build-obsproc) and
            ush/prepobs_makeprepbufr.sh(now in module prepobs)
            Merge branch 'develop' into release/obsproc.v1.0.0

        commit bd4211a
        Author: iliana Genkova <[email protected]>
        Date:   Mon Jan 3 19:23:04 2022 -0600

            Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

            * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
            -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

            * Clean up interpreter

        commit 309371d
        Author: Shelley Melchior <[email protected]>
        Date:   Mon Jan 3 18:25:21 2022 -0500

            created README.md

            Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

        commit c5342eb
        Author: Rahul Mahajan <[email protected]>
        Date:   Mon Jan 3 17:57:29 2022 -0500

            adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)

    commit e63a78c
    Author: Shelley Melchior <[email protected]>
    Date:   Wed Jun 1 16:21:51 2022 +0000

        Updated to correctly locate tcvitals file.

    commit 0bbb542
    Author: Shelley Melchior <[email protected]>
    Date:   Fri Apr 8 20:31:15 2022 +0000

        Incorporating changes made by NCO SPA following:
        restart of cactus and
        changing output data directory for mods

commit daff5af
Author: Shelley Melchior <[email protected]>
Date:   Fri May 27 18:05:05 2022 +0000

    Added section to cd to logfile output dir prior to process submission.

commit 30c01f9
Author: iliana Genkova <[email protected]>
Date:   Tue May 24 11:37:06 2022 -0500

    Set obsproc_ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2 (#38)

    * Set obsproc+ver=v1.0 and HOMEgfs=$COMROOT/gfs/v16.2

    * Introduce 3-digit obsproc_ver_pckg and use with $PACKAGEROOT

commit ebb6c68
Author: Cory Martin <[email protected]>
Date:   Tue Apr 12 15:15:47 2022 -0400

    Changes needed to build on Hera (#32)

commit 0075564
Author: Shelley Melchior <[email protected]>
Date:   Sat Apr 9 17:07:10 2022 -0400

    Incorporating changes made by NCO SPA following: (#35)

    restart of cactus and
    changing output data directory for mods

commit 59596a9
Author: Shelley Melchior <[email protected]>
Date:   Thu Apr 7 21:27:40 2022 +0000

    Removing top level README.md. This file now resides in docs/.

commit 735f009
Merge: bd4211a 8f28c00
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:51:34 2022 +0000

    Merge branch 'release/obsproc.v1.0.0' into develop

commit 8f28c00
Merge: f01f691 bd4211a
Author: Iliana Genkova <[email protected]>
Date:   Thu Apr 7 20:49:01 2022 +0000

    Removed build.sh (now in /build-obsproc) and
    ush/prepobs_makeprepbufr.sh(now in module prepobs)
    Merge branch 'develop' into release/obsproc.v1.0.0

commit bd4211a
Author: iliana Genkova <[email protected]>
Date:   Mon Jan 3 19:23:04 2022 -0600

    Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh: (#19)

    * Adopt Jack Woolen's (CFS) faster prepobs_makeprepbufr.sh:
    -use cfp with mpiexe -introduce FORT5 -move ksh interpreter

    * Clean up interpreter

commit 309371d
Author: Shelley Melchior <[email protected]>
Date:   Mon Jan 3 18:25:21 2022 -0500

    created README.md

    Created README.md to better explain installation instructions, modified to adopt NCO's working practices.

commit c5342eb
Author: Rahul Mahajan <[email protected]>
Date:   Mon Jan 3 17:57:29 2022 -0500

    adopt for current NCO working practices per discussion w/ StevenEarle et al (#18)
@ilianagenkova ilianagenkova deleted the feature/develop.fix_ver_HOMEgfs branch December 21, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShelleyMelchior-NOAA ShelleyMelchior-NOAA ShelleyMelchior-NOAA approved these changes

@AshleyStanfield-NOAA AshleyStanfield-NOAA AshleyStanfield-NOAA left review comments

Assignees

@ilianagenkova ilianagenkova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilianagenkova @ShelleyMelchior-NOAA @AshleyStanfield-NOAA