Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake cleanup in CCPP; cmake in FV3dycore #385

Closed
wants to merge 13 commits into from
Closed

cmake cleanup in CCPP; cmake in FV3dycore #385

wants to merge 13 commits into from

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Sep 10, 2021

Description

This PR:

Testing

How were these changes tested? RT's
What compilers / HPCs was it tested with? RT's
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? On what platform? In progress

  • Will the code updates change regression test baseline? No
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

ccpp/CMakeLists.txt Outdated Show resolved Hide resolved
@junwang-noaa
Copy link
Collaborator

Do we have CCPP PRs for this fv3 PR? can we list them in the Dependencies section?

@aerorahul
Copy link
Contributor Author

Do we have CCPP PRs for this fv3 PR? can we list them in the Dependencies section?

As soon as @climbfuji opens the relevant PR's, I will update the description here.

@climbfuji
Copy link
Collaborator

Do we have CCPP PRs for this fv3 PR? can we list them in the Dependencies section?

As soon as @climbfuji opens the relevant PR's, I will update the description here.

These PRs were opened many weeks ago ...

Associated PRs (see also ufs-weather-model PR):

NOAA-GFDL/GFDL_atmos_cubed_sphere#141
NCAR/ccpp-framework#382
NCAR/ccpp-physics#705
#385
ufs-community/ufs-weather-model#791

@aerorahul
Copy link
Contributor Author

Do we have CCPP PRs for this fv3 PR? can we list them in the Dependencies section?

done.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR, together with NOAA-GFDL/GFDL_atmos_cubed_sphere#141, changed the regression test results on AWS (CI) and Jet with Intel for yet unknown reasons.

@aerorahul
Copy link
Contributor Author

The atmosphere dycore build is treated differently than the other components of the UFS.
Isolating and fixing this issue will likely result in non-reproducible baseline due to this special handling.

@aerorahul aerorahul closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants