-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake cleanup in CCPP; cmake in FV3dycore #385
cmake cleanup in CCPP; cmake in FV3dycore #385
Conversation
* Cleanup of ccpp/CMakeLists.txt now that CCPP is defining build interfaces correctly
Do we have CCPP PRs for this fv3 PR? can we list them in the Dependencies section? |
As soon as @climbfuji opens the relevant PR's, I will update the description here. |
These PRs were opened many weeks ago ... Associated PRs (see also ufs-weather-model PR): NOAA-GFDL/GFDL_atmos_cubed_sphere#141 |
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR, together with NOAA-GFDL/GFDL_atmos_cubed_sphere#141, changed the regression test results on AWS (CI) and Jet with Intel for yet unknown reasons.
The atmosphere dycore build is treated differently than the other components of the UFS. |
Description
This PR:
Testing
How were these changes tested? RT's
What compilers / HPCs was it tested with? RT's
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? On what platform? In progress
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs