Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CCPP cmake build, reduce number of compile jobs, use atparse for variable substitution in MOM and CICE input files #791

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 10, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • [n/a] If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

  • Update submodule pointers for fv3atm, ccpp-framework and ccpp-physics for the changes described in the associated PRs below (cleanup CCPP cmake build)
  • Reduce the number of compile jobs by combining compilations that only differ in the -DCCPP_SUITES argument to the extent that the Intel compilers allow it (i.e. do not abort with internal compiler errors)
  • Ensure that only one WW3 compile job is running at any given time (no clean out-of-source build) - from @DusanJovic-NOAA
  • Contains PR Use atparse for variable subsitution in MOM and CICE input files #784 "Use atparse for variable substitution in MOM and CICE input files" from @DeniseWorthen
  • Also: increase wallclock time on Gaea to 2hrs (120mins) to deal with temporary variability in run times

Issue(s) addressed

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI - 6bbc709

Dependencies

Associated PRs:

DeniseWorthen and others added 30 commits March 27, 2021 12:30
This reverts commit 7b826d4.
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: RT
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/731093042/20210914101510/ufs-weather-model
Please manually delete: /glade/scratch/dtcufsrt/FV3_RT/rt_26714
Test control_ras 010 failed in run_test failed
Test control 001 failed in run_test failed
Please make changes and add the following label back:
cheyenne-gnu-RT

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/731093042/20210914100012/ufs-weather-model
Please manually delete: /glade/scratch/dtcufsrt/FV3_RT/rt_71724
Test cpld_control_c192 006 failed in run_test failed
Test control_flake 049 failed in run_test failed
Test control_csawmgt 048 failed in run_test failed
Test control_thompson 052 failed in run_test failed
Test cpld_bmark_v16 010 failed failed
Test cpld_bmark_v16 010 failed in run_test failed
Please make changes and add the following label back:
cheyenne-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: RT
Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/731093042/20210914160006/ufs-weather-model
Please manually delete: /lustre/f2/scratch/emc.nemspara/FV3_RT/rt_3648
Test compile 009 failed failed
Test control_thompson_no_aero 053 failed failed
Test control_thompson_no_aero 053 failed in run_test failed
Please make changes and add the following label back:
gaea-intel-RT

@climbfuji
Copy link
Collaborator Author

Cheyenne tests failed due to disk quota issues (presumably), I cleared the scratch area, will add labels for GNU and Intel one after the other. Gaea: Will rerun failed tests manually.

@climbfuji
Copy link
Collaborator Author

Except for orion, all regression tests finished and were successful. On Orion, we still have several jobs in the queue.

@climbfuji
Copy link
Collaborator Author

Except for orion, all regression tests finished and were successful. On Orion, we still have several jobs in the queue.

All tests on orion passed so far, one remaining one is still running. I am going to start merging ccpp-framework and ccpp-physics.

@climbfuji
Copy link
Collaborator Author

I verified hash for fv3atm to be correct (85c2648).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
6 participants