Cleanup CCPP cmake build #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…physics for code review and testing
ccpp/CMakeLists.txt
Outdated
Comment on lines
97
to
102
| # | ||
| #add_dependencies(ccppphys ccpp) | ||
| #target_link_libraries(ccppphys PUBLIC w3nco::w3nco_d NetCDF::NetCDF_Fortran) | ||
| ## This should not be necessary once framework and physics targets define BUILD_INTERFACE | ||
| #target_include_directories(ccppphys PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/framework/src) | ||
| # *DH |
There was a problem hiding this comment.
Let's remove this if it's not necessary anymore.
There was a problem hiding this comment.
I just saw a TODO comment in the PR description.
There was a problem hiding this comment.
I think I still need to add w3nco::w3nco_d somewhere in ccpp-physics's CMakeLists.txt, because the compile jobs are now failing with
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/731093042/20210910021510/ufs-weather-model/FV3/ccpp/physics/physics/sfcsub.F:8551: undefined reference to `w3kind_'
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/731093042/20210910021510/ufs-weather-model/FV3/ccpp/physics/physics/sfcsub.F:8554: undefined reference to `w3movdat_'
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/731093042/20210910021510/ufs-weather-model/FV3/ccpp/physics/physics/sfcsub.F:8599: undefined reference to `getgbh_'
...
@DusanJovic-NOAA Am I correct?
There was a problem hiding this comment.
Yes, add it either in ccpp_physics, in which case you'll need to 'find' w3nco package there, if you want to have ccpp physics compilable outside UFS. Or just uncomment 'target_link_library' here to define dependency of ccpp_physics target on w3nco.
|
sfcsub.F needs "grib1" software.
…On Fri, Sep 10, 2021 at 9:11 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ccpp/CMakeLists.txt
<#383 (comment)>:
> +#
+#add_dependencies(ccppphys ccpp)
+#target_link_libraries(ccppphys PUBLIC w3nco::w3nco_d NetCDF::NetCDF_Fortran)
+## This should not be necessary once framework and physics targets define BUILD_INTERFACE
+#target_include_directories(ccppphys PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/framework/src)
+# *DH
I think I still need to add w3nco::w3nco_d somewhere in ccpp-physics's
CMakeLists.txt, because the compile jobs are now failing with
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/731093042/20210910021510/ufs-weather-model/FV3/ccpp/physics/physics/sfcsub.F:8551: undefined reference to `w3kind_'
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/731093042/20210910021510/ufs-weather-model/FV3/ccpp/physics/physics/sfcsub.F:8554: undefined reference to `w3movdat_'
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/731093042/20210910021510/ufs-weather-model/FV3/ccpp/physics/physics/sfcsub.F:8599: undefined reference to `getgbh_'
...
@DusanJovic-NOAA <https://github.com/DusanJovic-NOAA> Am I correct?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#383 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYQXQ65CGJ2D47PIOWLUBH7WXANCNFSM5DYKWOUQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
|
junwang-noaa
approved these changes
Sep 14, 2021
DusanJovic-NOAA
approved these changes
Sep 14, 2021
…ramework and ccpp-physics
|
Submodule pointers for ccpp-framework and ccpp-physics have been verified. Orion/Intel testing just completed successfully. |
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Jun 13, 2022
…or porting and threading issues (NOAA-EMC#383) * CI passed at commit 464a90e prior to review. * Note: Orion RTs failed because of system work. Co-authored-by: Jessica Meixner <[email protected]> Co-authored-by: Brian Curtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up
ccpp/CMakeLists.txt, because the associated PRs below for ccpp-framework and ccpp-physics now define their targets and dependencies correctly.Issue(s) addressed
Testing
See ufs-community/ufs-weather-model#791.
Dependencies
NCAR/ccpp-framework#382
NCAR/ccpp-physics#705
#383
ufs-community/ufs-weather-model#791