-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cheyenne.pgi from CCPP config #117
Remove cheyenne.pgi from CCPP config #117
Conversation
Note: I flagged this PR and associated PRs as "ready to merge" in case these make it to the top of the commit queue during my two days of holidays. Please do not merge unless agreed upon with @DusanJovic-NOAA and @junwang-noaa. |
@junwang-noaa do you know why the changes related to tiice are still showing up in my PR? I thought this was merged last week? Attached is a screenshot of the diffs between develop as of today (left), and my code (right). I don't see any of those differences that GitHub is talking about. All clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused, why the code changes in PR #119 are here?
118ec79
to
47e1219
Compare
Ok, fixed now. I think this was because I had pulled in Shan's changes before they got merged, but the merge was a squashed-merge and GitHub got confused. I did a |
remove cheyenne.pgi from CCPP config (ccpp/set_compilers.sh, ccpp/build_ccpp.sh)
* Add NSSL 2-Moment Microphysics * Update data structures to handle the additional tracer species in NSSL microphysics * Add the code files for NSSL microphysics to the CCPP prebuild config * Add suite for NSSL microphysics * Add a CCPP suite to test NSSL microphysics * Initialize ice fluxes and add "tiice" array (#119) (1) Introducing a separate array "tiice" to store internal ice temperature. "tiice" will be added to phyf*nc output only when frac_grid=T. (2) When cplflx=T, initializing ice fluxes by PBL calculated values when fluxes from CICE are unavailable. (3) Adding frac_grid to namelist and no longer modifying it inside FV3GFS_io.F90. frac_grid=F by default. * Remove cheyenne.pgi from CCPP config (#117) remove cheyenne.pgi from CCPP config (ccpp/set_compilers.sh, ccpp/build_ccpp.sh) * develop: merge HWRF version of saSAS with GFS version (#93) * Merge branch 'man_hafs_sas_without_updates_of_dtc_develop_49b73a8f4149ca88f071dbaae81f1769b120f1e0' into HEAD * gfsphysics/physics/GFS_debug.F90: add capability to debug 1-d logical arrays * Clean up error messages in gfsphysics/GFS_layer/GFS_typedefs.F90 Co-authored-by: Dusan Jovic <[email protected]> * Merge GFDL FV3 dynamic core new (201912) version (#65) * Change 'mytile' to 'mygrid' corresponding to the change in atmos_cubed_sphere * GFS.v16.0.4 physics update (#128) * physics update from GFS.v16.0.4 * GFS.v16.0.4 physics udpate * remove whitespaces in sfc_diff.f * keep z0 unchanged in coupled mode in sfc_diff.f * fix IPD run * point to NCAR ccpp-physics branch Co-authored-by: Jun Wang <[email protected]> * Update for GFDL_atmos_cubed_sphere (dycore GNU bugfix) (#131) * Bugfix for regional runs when dycore is compiled in double precision (#133) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere * Update develop from gsd/develop 2020/06/30 (#134) - output of auxiliary arrays (2d, 3d) from CCPP to assist developers debugging their physics - correctly output 3-dim tendencies for t, u, v, qv, ozone from CCPP physics - mandatory changes for the CCPP framework updates to handle blocked data structures correctly: fix inconsistent use of `horizontal_dimension` (ix) versus `horizontal_loop_extent` (im) and other metadata corrections - remove old pset logic from `ccpp_prebuild_config.py` (was required for CCPP dynamic build) - updates to all suite definition files: change the order of interstitial schemes get_phi_fv3+GFS_suite_interstitial_3 and GFS_DCNV_generic_pre to match the logical flow (does not change the answer) - move CCPP physics initialization calls in `atmos_model.F90` so that the physics can see the data from the restart files at initialization time - add capability to read large-scale and small-scale orographic data when using GSL drag suite - add additional fields to restart files as required for GSL physics updates - new suite definition files for RAP and HRRR configurations - capability to call radiation for the first `nhfrad` physics time steps for cold starts, afterwards on the cycle defined by the radiation time step * Add regression tests with MULTI_GASES (#108) * Update suite_FV3_GFS_2017_fv3wam.xml * Remove unnecessary file from the CCPP prebuild configuration * Add TACC frontera configuration * Update to RAS in CCPP, update submodule pointer for ccpp-framework (CI tests) (NOAA-EMC#252) * Reactivate mass flux arrays * fix the argument list in inline_post_getattr and remove prints and post_gfs_stub.F90 * ccpp/data/GFS_typedefs.F90: correct initialization of Model%fscav * Add FV3_GFS_v16_ras * Cld perts (NOAA-EMC#233) Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run. Also, addition of stochastic cloud perturbation and microphyiscs perturbations for SPPT. * upgrade OPAC aerosol with more advanced MERRA2 aerosol (NOAA-EMC#254) * changed .gitmodules to point to merra2 ccpp/physics * revert .gitmodule * update to Larissa version * add atmos_cube_sphere and ccpp/physics as submodules * add submodules of emc-2021-cloud * update ccpp/physics: remove CAPS version mp_nssl_2mom * ccpp/physics update: fix nssl mp reproducibility issue * Updating pointer to ccpp/physics. * Pointing to Christin's branch * Adding new suite for NSSL physics. * Updating suites to match HWT. * Updating gitmodules * Updating pointer to atmos_cubed_sphere. Co-authored-by: Tim Supinie <[email protected]> Co-authored-by: shansun6 <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> Co-authored-by: Dusan Jovic <[email protected]> Co-authored-by: XiaqiongZhou-NOAA <[email protected]> Co-authored-by: Jun Wang <[email protected]> Co-authored-by: Jun Wang <[email protected]> Co-authored-by: Phil Pegion <[email protected]> Co-authored-by: AnningCheng-NOAA <[email protected]> Co-authored-by: Jili Dong <[email protected]>
…m_develop_20211116 Update gsl/develop from develop 202/11/17
* Create examples README.md * Reorganizing files in docs/ directory * Added advection notebook * Fixed subplot spacing * New 3D case notebooks * Added notebooks * Update README.md
* Removing use of mpp_io_mod and fms_io_mod from the dycore code. Replacing the necessary functions with fms2_io_mod functions * Adding a call to set_filename_appendix so that nest is added to filename when needed and removing unneccessary code in fv_io_mod * FV3 Documentation - formatted PDF and source files for FV3 documentation. * Documentation and defaults changes - Updated defaults for hord options to use 8 and 10, and removal of mention of hord = 9 (experimental, unsupported) scheme. * Initialize {sw,se,nw,ne}_corner to .false in model/fv_arrays.F90 (cherry picked from commit bf0630f) * merge of latest dev work from GFDL Weather and Climate Dynamics Division (NOAA-EMC#114) * read ak/bk from user specified files (NOAA-EMC#115) * add input.nml parameter fv_eta_file for user specified ak/bk; change ks calculation when npz_type=input; use newunit to replace fixed file unit for npz_type=input (cherry picked from commit 3a0d35a) * FV3 Example Notebooks and cleanup of docs directory (NOAA-EMC#117) * removed module use of INPUT_STR_LENGTH in fv_control.F90 (NOAA-EMC#122) * add check on eta levels to ensure their monotonicity * update Jili Dong's ak/bk external input to - use the FMS ascii_read (single read/broadcast) - error check input to ensure the proper number of levels present * added a format description for the external eta file and ensured a correct the file length check for FMS 2021.03 and greater * merge of minor updates from GFDL Weather and Climate Dynamics Division (20210804) (NOAA-EMC#127) Co-authored-by: Lauren Chilutti <[email protected]> Co-authored-by: laurenchilutti <[email protected]> Co-authored-by: lharris4 <[email protected]> Co-authored-by: Dusan Jovic <[email protected]> Co-authored-by: Jili Dong <[email protected]>
This PR:
cheyenne.pgi
from CCPP config (ccpp/set_compilers.sh
,ccpp/build_ccpp.sh
)Associated PRs:
NCAR/ccpp-framework#295
#117
NOAA-EMC/NEMS#63
ufs-community/ufs-weather-model#139
For regression testing information, see below ufs-community/ufs-weather-model#139.