-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge radar_tten support for the tenth time. #119
Merge radar_tten support for the tenth time. #119
Conversation
url = https://github.com/NOAA-GSL/ccpp-physics | ||
branch = gsl/develop | ||
url = https://github.com/SamuelTrahanNOAA/ccpp-physics | ||
branch = feature/gsl-develop-20211203-radar-tten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This points to your branch. Is this intended? If Yes, you will change this later, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. You have to do this until a merge so people can clone your branch from the ufs-weather-model level.
Note that we should update gsl/develop from the authoritative repositories first before we merge this PR. This is so that we have a version/hash that is 100% identical with the authoritative repository as of beginning of this week. |
Yes. Or perhaps I should do a new PR to the community repositories instead? Either way, someone will have to retest this. |
Sam, I can test it again when you have a new PR. |
@climbfuji The gsl/develop branch is still on November 24, 2021 with hash: Those two are identical, right? Thanks, |
They are not. The Dec 13 hash has changes from the authoritative repositories that have not been merged into gsl/develop yet, in particular the entire revamp of the GSL/RAP regression tests. |
Closing this so I can do a PR to the community repository. |
Temperature tendencies in microphysics scheme replaced with radar-derived values for the first N minutes of the model run.