Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RAS in CCPP, update submodule pointer for ccpp-framework (CI tests) #252

Merged
merged 11 commits into from
Mar 17, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 4, 2021

Description

This PR does the following:

Issue(s) addressed

Fixes #235
Fixes ufs-community/ufs-weather-model#476

Testing

See ufs-community/ufs-weather-model#448.

Dependencies

NCAR/ccpp-physics#585
#252
ufs-community/ufs-weather-model#448

@climbfuji climbfuji marked this pull request as ready for review March 15, 2021 19:48
@climbfuji climbfuji changed the title Update to RAS in CCPP Update to RAS in CCPP, update submodule pointer for ccpp-framework (CI tests) Mar 15, 2021
@SMoorthi-emc
Copy link
Contributor

we need to add
" ! -- setup aerosol scavenging factors
n = max(Model%ntrac, Model%ntchm)
allocate(Model%fscav(n))
Model%fscav = -9999.0"
replacing
"allocate(Model%fscav(Model%ntchm))"
in GFS_typedef.F90

@@ -0,0 +1,94 @@
<?xml version="1.0" encoding="UTF-8"?>

<suite name="FV3_GFS_v15p2_ras" version="1">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to create a suite_FV3_GFS_v16_ras.xml suite file? The operational GFSv16 will be implemented this week, and we hope to update global suite files to be GFS_v16 based.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced ccpp/suites/suite_FV3_GFS_v15p2_ras.xml with ccpp/suites/suite_FV3_GFS_v16_ras.xml and also changed the regression tests in the ufs-weather-model PR.

@SMoorthi-emc
Copy link
Contributor

It should be simple to do; just take the suite with sas and replace
" samfdeepcnv"
with
" rascnv"
and change the suite name.

@climbfuji
Copy link
Collaborator Author

we need to add
" ! -- setup aerosol scavenging factors
n = max(Model%ntrac, Model%ntchm)
allocate(Model%fscav(n))
Model%fscav = -9999.0"
replacing
"allocate(Model%fscav(Model%ntchm))"
in GFS_typedef.F90

Done.

@climbfuji
Copy link
Collaborator Author

Ready to merge.

@junwang-noaa junwang-noaa merged commit dbaff1c into NOAA-EMC:develop Mar 17, 2021
christinaholtNOAA added a commit to NOAA-GSL/fv3atm that referenced this pull request Jun 15, 2021
* Add NSSL 2-Moment Microphysics

* Update data structures to handle the additional tracer species in NSSL microphysics
* Add the code files for NSSL microphysics to the CCPP prebuild config

* Add suite for NSSL microphysics

* Add a CCPP suite to test NSSL microphysics

* Initialize ice fluxes and add "tiice" array (#119)

(1) Introducing a separate array "tiice" to store internal ice temperature. "tiice" will be added to phyf*nc output only when frac_grid=T.
(2) When cplflx=T, initializing ice fluxes by PBL calculated values when fluxes from CICE are unavailable.
(3) Adding frac_grid to namelist and no longer modifying it inside FV3GFS_io.F90. frac_grid=F by default.

* Remove cheyenne.pgi from CCPP config (#117)

remove cheyenne.pgi from CCPP config (ccpp/set_compilers.sh, ccpp/build_ccpp.sh)

* develop: merge HWRF version of saSAS with GFS version (#93)

* Merge branch 'man_hafs_sas_without_updates_of_dtc_develop_49b73a8f4149ca88f071dbaae81f1769b120f1e0' into HEAD
* gfsphysics/physics/GFS_debug.F90: add capability to debug 1-d logical arrays
* Clean up error messages in gfsphysics/GFS_layer/GFS_typedefs.F90

Co-authored-by: Dusan Jovic <[email protected]>

* Merge GFDL FV3 dynamic core new (201912) version (#65)

* Change 'mytile' to 'mygrid' corresponding to the change in atmos_cubed_sphere

* GFS.v16.0.4 physics update (#128)

* physics update from GFS.v16.0.4
* GFS.v16.0.4 physics udpate
* remove whitespaces in sfc_diff.f
* keep z0 unchanged in coupled mode in sfc_diff.f
* fix IPD run
* point to NCAR ccpp-physics branch

Co-authored-by: Jun Wang <[email protected]>

* Update for GFDL_atmos_cubed_sphere (dycore GNU bugfix) (#131)

* Bugfix for regional runs when dycore is compiled in double precision (#133)

* Update .gitmodules and submodule pointer for fv3atm for code review and testing

* Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere

* Update develop from gsd/develop 2020/06/30 (#134)

- output of auxiliary arrays (2d, 3d) from CCPP to assist developers debugging their physics
- correctly output 3-dim tendencies for t, u, v, qv, ozone from CCPP physics
- mandatory changes for the CCPP framework updates to handle blocked data structures correctly: fix inconsistent use of `horizontal_dimension` (ix) versus `horizontal_loop_extent` (im) and other metadata corrections
- remove old pset logic from `ccpp_prebuild_config.py` (was required for CCPP dynamic build)
- updates to all suite definition files: change the order of interstitial schemes get_phi_fv3+GFS_suite_interstitial_3 and GFS_DCNV_generic_pre to match the logical flow (does not change the answer)
- move CCPP physics initialization calls in `atmos_model.F90` so that the physics can see the data from the restart files at initialization time
- add capability to read large-scale and small-scale orographic data when using GSL drag suite
- add additional fields to restart files as required for GSL physics updates
- new suite definition files for RAP and HRRR configurations
- capability to call radiation for the first `nhfrad` physics time steps for cold starts, afterwards on the cycle defined by the radiation time step

* Add regression tests with MULTI_GASES (#108)

* Update suite_FV3_GFS_2017_fv3wam.xml

* Remove unnecessary file from the CCPP prebuild configuration

* Add TACC frontera configuration

* Update to RAS in CCPP, update submodule pointer for ccpp-framework (CI tests) (NOAA-EMC#252)

* Reactivate mass flux arrays
* fix the argument list in inline_post_getattr and remove prints and post_gfs_stub.F90
* ccpp/data/GFS_typedefs.F90: correct initialization of Model%fscav
* Add FV3_GFS_v16_ras

* Cld perts (NOAA-EMC#233)

Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run.  
Also, addition of stochastic cloud perturbation and microphyiscs perturbations for SPPT.

* upgrade OPAC aerosol with more advanced MERRA2 aerosol (NOAA-EMC#254)

* changed .gitmodules to point to merra2 ccpp/physics
* revert .gitmodule

* update to Larissa version

* add atmos_cube_sphere and ccpp/physics as submodules

* add submodules of emc-2021-cloud

* update ccpp/physics: remove CAPS version mp_nssl_2mom

* ccpp/physics update: fix nssl mp reproducibility issue

* Updating pointer to ccpp/physics.

* Pointing to Christin's branch

* Adding new suite for NSSL physics.

* Updating suites to match HWT.

* Updating gitmodules

* Updating pointer to atmos_cubed_sphere.

Co-authored-by: Tim Supinie <[email protected]>
Co-authored-by: shansun6 <[email protected]>
Co-authored-by: Dom Heinzeller <[email protected]>
Co-authored-by: Dusan Jovic <[email protected]>
Co-authored-by: XiaqiongZhou-NOAA <[email protected]>
Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: Phil Pegion <[email protected]>
Co-authored-by: AnningCheng-NOAA <[email protected]>
Co-authored-by: Jili Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants