Updates from v2 #626
Updates from v2 #626
Conversation
…ashes release/public-v5: bugfixes for GNU 10 crashes
Remove references to GMTB in SCM-related files
…ric_post_bugfix GFS_MP_generic.F90 conditional allocation bugfix
CCPPv5.0.0 scientific doc sync
llpcarson
requested review from
climbfuji,
grantfirl and
JulieSchramm
as code owners
|
Has the Scientific Documentation been parsed with Doxygen and shown to produce same/similar results as the CCPP v5.0.0 release (https://dtcenter.ucar.edu/GMTB/v5.0.0)? |
I have not, @mzhangw , did you do this with your branch? If not, could you do that? Thanks! |
|
@llpcarson With the merge conflicts, it looks like this branch needs to be merged with the latest master, right? |
|
Yes, and this will have to happen a few more times I guess. The commit queue is long ... |
|
Yes, I'll need to do another merge with master. I am thinking it makes sense to wait until the current round of PRs goes in, and do another merge (and fix conflicts) then. |
I usually have my code up to date when I create the PRs to start the review process, but then don't update anymore until it is time to commit. Everything else is just a waste of time in my opinion. |
|
Agreed - it was up-to-date yesterday, and I'll wait until closer to commit-time to update again and re-test |
|
Totally fine by me. I was just looking to test this branch with the SCM and noticed the conflicts, but it turns out that the SCM branch that I'm testing this ccpp-physics branch with is also not updated to the latest master, so there is actually no problem for me. |
scidoc fix for PR626
|
I am thinking that sfcsub is more part of GFS_phys_time_vary for surface cycling based on the calling structure.It is not associated with a specific scheme as you pointed out. how about we take a note and change it in the future?
… On Apr 20, 2021, at 7:55 AM, Dom Heinzeller ***@***.***> wrote:
@climbfuji commented on this pull request.
In physics/sfcsub.F <#626 (comment)>:
> @@ -3,7 +3,7 @@
!>\defgroup mod_sfcsub GFS sfcsub Module
-!!\ingroup LSMs
+!!\ingroup Noah_LSM
Why is this for Noah_LSM only ? sfcsub.F also gets used with Noah MP and RUC.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#626 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2W6XUTBFFF7M6WXFCDTJWBWBANCNFSM426HE5JQ>.
|
How about changing it as part of this PR? Would be easy to do for Laurie. |
|
I can do it
… On Apr 20, 2021, at 9:20 AM, Dom Heinzeller ***@***.***> wrote:
I am thinking that sfcsub is more part of GFS_phys_time_vary for surface cycling based on the calling structure.It is not associated with a specific scheme as you pointed out. how about we take a note and change it in the future?
… <x-msg://18/#>
How about changing it as part of this PR? Would be easy to do for Laurie.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2UFPZOO6FQEXWDTKHTTJWLTVANCNFSM426HE5JQ>.
|
|
I updated the branch with Man's change, but will wait to update the submodule pointers until the next merge/update is in |
Updates from the ufs-weather-model release v2.0.0 (CCPP release 5.0.0), including:
Fixes #581
Related PRs
ufs-community/ufs-weather-model#521
NOAA-EMC/NEMS#96
NOAA-EMC/fv3atm#280
NOAA-GFDL/GFDL_atmos_cubed_sphere#94