Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG floating point exception bugfix #573

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Feb 19, 2021

fix one line in micro_mg3_0.F90 to avoid a divide by zero floating point exception in SCM debug mode

@grantfirl
Copy link
Collaborator Author

grantfirl commented Feb 19, 2021

Fixes #574

Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good find!

@climbfuji climbfuji merged commit 56cd7d0 into NCAR:release/public-v5 Feb 22, 2021
DusanJovic-NOAA pushed a commit to NOAA-EMC/fv3atm that referenced this pull request Feb 23, 2021
#250)

Update the submodule pointers for GFDL_atmos_cubed_sphere (documentation only) and ccpp-physics (SCM related changes in physics, but with one shared file being modified):

NCAR/ccpp-physics#573 (Morrison-Gettelman MP floating point exception bugfix)
NCAR/ccpp-physics#576 (Remove references to GMTB in SCM-related files)
NCAR/ccpp-physics#577 (GFS_MP_generic.F90 conditional allocation bugfix)
@grantfirl grantfirl mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants