release/public-v5: bugfixes for GNU 10 crashes #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sics/GFS_rrtmg_pre.{F90,meta} which cause crashes with GNU 10
…itial schemes for arrays that are only allocated under certain conditions
This was referenced Jan 4, 2021
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
llpcarson
approved these changes
Jan 5, 2021
XiaSun-Atmos
approved these changes
Jan 5, 2021
|
@grantfirl Please update the submodule pointer in scm release/public-v5 accordingly when you are making your next updates there. Thank you! |
llpcarson
pushed a commit
to llpcarson/ccpp-physics
that referenced
this pull request
Mar 24, 2021
…ashes release/public-v5: bugfixes for GNU 10 crashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains bugfixes to prevent model runs from crashing when using gfortran 10.x.y. All these changes are related to using assumed-size array declarations in several primary and interstitial schemes for arrays that are allocated only under certain conditions.
Some of these changes were contributed by @DusanJovic-NOAA.
Associated PRs:
#540
NOAA-EMC/fv3atm#221
ufs-community/ufs-weather-model#355
For regression testing, see ufs-community/ufs-weather-model#355.