bug-fix and code clean-up #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes including timeseries generation and copy_html. Tested with the latest CIME tag and st_archive location of files which resulted in changing the path location of ocn log and cpl log files in config_diags_ocn.xml. Postprocessing of older datasets will need to be aware of these path changes for ocean timeseries plots to work correctly. Test suite: 5 years of test.f09_g16.BC5L45BGC data Fixes [Github issue #]: These bug-fixes weren't in the github issues but rather reported directly to me via email. User interface changes: config_ocn_diags.xml - <entry id="OCNDIAG_CPLLOGFILEPATH" value="$DOUT_S_ROOT/logs" /> <entry id="OCNDIAG_OCNLOGFILEPATH" value="$DOUT_S_ROOT/logs" /> Input data changes: none Code review:
bertinia
added a commit
to bertinia/CESM_postprocessing
that referenced
this pull request
Feb 15, 2018
018f31f Merge pull request NCAR#44 from NCAR/devel f28eccb Merge pull request NCAR#43 from NCAR/char_bug 6fbc661 Bump verison number 92a2b8c Merge pull request NCAR#42 from NCAR/char_bug e67cc3a Update to the previous fix: 37afc58 Merge pull request NCAR#41 from NCAR/char_bug e4b2715 Fix bug with character identification. The code was only checking for 'S1'. Compressed netcdf4 files identify characters as 'S3'. e3f121e Merge pull request NCAR#40 from NCAR/devel 28f36ec Merge pull request NCAR#38 from NCAR/devel 3563c85 Merge pull request NCAR#35 from NCAR/devel 0f5eb0b Merge pull request NCAR#34 from NCAR/devel 34747e1 Merge pull request NCAR#29 from NCAR/devel fa67fce Merge pull request NCAR#26 from NCAR/devel 4ac6f44 Merge pull request NCAR#24 from NCAR/devel 3fc272d Merge pull request NCAR#22 from NCAR/devel 108739b Merge pull request NCAR#20 from NCAR/devel 490ba39 Merge pull request NCAR#18 from NCAR/devel d34c46e Merge pull request NCAR#15 from NCAR/devel d2290b6 Merge pull request NCAR#9 from NCAR/devel 2436413 Merge pull request NCAR#6 from NCAR-CISL-ASAP/devel 2125a4f Merge pull request NCAR#4 from NCAR-CISL-ASAP/devel c51daf1 Merge pull request NCAR#1 from NCAR-CISL-ASAP/devel git-subtree-dir: averager/pyAverager git-subtree-split: 018f31ff4013fa0b240470003f27025811aeaf11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes including timeseries generation and copy_html.
Tested with the latest CIME tag and st_archive location of files
which resulted in changing the path location of ocn log and cpl log
files in config_diags_ocn.xml. Postprocessing of older datasets
will need to be aware of these path changes for ocean timeseries
plots to work correctly.
Test suite: 5 years of test.f09_g16.BC5L45BGC data
Fixes [Github issue #]: These bug-fixes weren't in the github issues but
rather reported directly to me via email.
User interface changes: config_ocn_diags.xml -
Input data changes: none
Code review: