Minor bug fix for lnd_diag #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keith Oleson's bug fix to lnd_diag/shared/lnd_func.ncl Test suite: Fixes [Github issue #]: N/A User interface changes: none Input data changes: none Code review: Keith Oleson
bertinia
added a commit
to bertinia/CESM_postprocessing
that referenced
this pull request
Aug 30, 2017
c09f5f5 Merge pull request NCAR#36 from NCAR/devel d6c7e22 Updating documentation 0ac645e Merge pull request NCAR#35 from NCAR/niobugfixing 76bb037 Splitting up NetCDf4 and Nio tests into different suites 961e4b1 Fixing character variable write with PyNIO to match netCDF4 c5f3021 More debugging output f36c5b5 Adding seperate Nio test cases fd51203 Adding debugging info d489987 Convert data type to 'c' when using Nio ad70673 Bumping version. Removing error on Nio use for testing. 90d423c Use fill_value property when checking fill_values e0dfe5e Merge pull request NCAR#34 from NCAR/devel 73f6a9d Merge pull request NCAR#33 from NCAR/bugfix_land_model c20625a Adding documentation updates c1ef9f7 Tests seem finicky with MPICH. Didn't see this with OpenMPI. 0dae4ae Commenting out PyNIO test a56b092 Disabling PyNIO backend due to current problems 43691ae Formatting only. 052a18a Cleaner output in tests and comment out Nio tests 2883138 bumping version 7be4bce Add support for variable name in NCVariable e9956f3 Rename file d6acc46 I think I finally have the string/char variables fixed 758aae4 Working toward a working solution with PyNIO string-types a3e3d18 Merge remote-tracking branch 'origin/devel' into bugfix_land_model 60e22c8 Merge pull request NCAR#32 from NCAR/devel fac02e3 Adding documentation 4e44b9f Updating documentation using Sphinx 177a96e Continuing to fix/improve tests (iobackground) c24c588 Some tests are segfaulting! Need to find them! 7ad483f Better test name output ad60274 Special handling of _FillValue when creating variables efbd6c4 Special handling of _FillValue attributes aad15cc Fixed bugs and improved parallel testing scripts 57934a4 New style for s2srun tests 9f28bb6 Formatting of help message c3dd881 Trying new s2srun test suite f4f94b7 Formatting 523a263 Added tests for different backends 9fd3723 Formatting only f8822f1 Greatly simplified and improved parallel reshaper testing fc8e7b1 Adding netcdf files to ignores 8583c20 Improving/fixing unit tests 3d27290 Formatting only 6aa3f6b Formatting only bd67d9a Extra debugging info to detect which variable is failing 4ed801b Project file update c1e19b7 Debugging ingo 2c2acd5 Debugging info 7be1360 Debugging output 96f3308 bump version 9932a7d Formatting only b733871 Some new documentation preparation a53586d Adding Eclipse settings directory 7b815fa Adding info to log output about communicator size ead3c69 Merge pull request NCAR#31 from NCAR/devel c6606c3 Merge pull request NCAR#30 from NCAR/master c85a2df Adding function to retrieve filesystem block size for IOPS computation 1ecd739 Adding bugfix for reading/writing scalar variables e7d9794 README Formatting only 7345950 Updating Copyright date to 2017 cc55fdf Updating copyright date to 2017 git-subtree-dir: reshaper/pyReshaper git-subtree-split: c09f5f522fc3ec19c017d3921046596c10271f55
bertinia
added a commit
to bertinia/CESM_postprocessing
that referenced
this pull request
Jan 17, 2018
f46c647 Merge branch 'master' of bitbucket.org:ncollier/ilamb 369c433 added an option for plotting a colorbar directly on the map plots 79a6eeb added a check on the units of the depth dimension from netCDF4 files c805be1 enabled plot_unit and table_unit in IOMB configure files eb60316 improved heuristics of summary plots 174431f fixed scores, reverting back to what they were a few commits ago 911e39c missed a conditional 8efb687 need to force this mask for some reason 49da324 apply intersection mask directly to variables, use the intersection for the regional means afb2091 mispelling 9c21a55 added protection for if no scores are foudn in the metrics table 0ebb8f9 added some safety to guard against nan's appearing in the functional relationship scoring process 903baf9 land areas may be masked and cause overflow errors due to large marked values (1e23), added ignores across multiply 3db7f84 revamped the relationship summary figure 0b8d777 fixed an issue in allmodels pages when no legends were present in figures e55f41b added a composite accumulation plot to nbp 251972e updated gold scores to match changes, some large shifts occur (~10%) mainly in the spatial distribution as we have now moved back to composite grids 6189cb0 added sig digits control to the dataset pages b6af223 needs to be https 488d019 fixed the all models page 6a50632 fix for if no values are in the table c37e8e0 Merge branch 'ncollier/revert-method' of bitbucket.org:ncollier/ilamb into ncollier/revert-method 3e145a8 added category scoring 1075b88 Merge branch 'master' into ncollier/revert-method db145a5 forced all score limits to [0,1] 8686802 removed dateline plotting which was causing issues 0a13357 fixed defaults 2d1ae6d fixed relationship pages 6ff549b generalized main page, relationship page broken 4bbd9d0 added a tropical biomass dataset to the ilamb canon 744a16b first stab at reintegration 3fe2e67 improvements to interpolation and cell areas 12ac6c3 included accounting for overlapping areas 0730ccd the definition of the global region was cause the halo of cells around the domain edges to become masked resulting in slightly lower integrated values than should be seen. Hard code this to never mask anything 1ddb467 we are seeing odd behavior in basemap plotting, keeping the datum at the origin unless strictly necesary seems to help a22630d initial rework c692c08 updated to 2.2 870cc1a restored GEOCARBON to the biomass comparisons 5b07aad added a default bg color 9d43919 added a check for distance away from nearest neighbor to help non aligned grids 97ae171 improved check for plot across dateline db78922 improved model extents check and error messages for when variables are not present in a model 7cdfa19 mistake in weeding out possibilities for lat/lon grids 5e8c7e6 checking for spatial extents of a model must be different with the possiblity of 2D grids, minor changes in test scores 86e0224 forgot to add depth information when combining variables from separate files be2b795 If we assemble a variable from single time slice files with no bounds present, then the combined variable has incorrect time bounds. Detect this and recompute in the Variable constructor ae2c627 moved to a uniform treatment of dimension bounds, if size is 1, then the bounds are the variable itself ab6db1b bounds may be listed but the variable not in the netCDF file 1dcceed allow for models to be sites, reduce the number of sites if not found fca0231 rework of the dimension indentification algorithm to relax description requirements in netCDF files 086cf58 Merge commit '95d3deb' 95d3deb fix a plotting error which occurs on older versions of matplotlib 86ee8a2 removed burned area products per Jim's request b721584 fixed a bug with derived expressions, more details in Issue NCAR#35 git-subtree-dir: ilamb/ilamb git-subtree-split: f46c64782ae40557e8f93d4df42ec98a458e2c9e
bertinia
added a commit
to bertinia/CESM_postprocessing
that referenced
this pull request
Feb 15, 2018
018f31f Merge pull request NCAR#44 from NCAR/devel f28eccb Merge pull request NCAR#43 from NCAR/char_bug 6fbc661 Bump verison number 92a2b8c Merge pull request NCAR#42 from NCAR/char_bug e67cc3a Update to the previous fix: 37afc58 Merge pull request NCAR#41 from NCAR/char_bug e4b2715 Fix bug with character identification. The code was only checking for 'S1'. Compressed netcdf4 files identify characters as 'S3'. e3f121e Merge pull request NCAR#40 from NCAR/devel 28f36ec Merge pull request NCAR#38 from NCAR/devel 3563c85 Merge pull request NCAR#35 from NCAR/devel 0f5eb0b Merge pull request NCAR#34 from NCAR/devel 34747e1 Merge pull request NCAR#29 from NCAR/devel fa67fce Merge pull request NCAR#26 from NCAR/devel 4ac6f44 Merge pull request NCAR#24 from NCAR/devel 3fc272d Merge pull request NCAR#22 from NCAR/devel 108739b Merge pull request NCAR#20 from NCAR/devel 490ba39 Merge pull request NCAR#18 from NCAR/devel d34c46e Merge pull request NCAR#15 from NCAR/devel d2290b6 Merge pull request NCAR#9 from NCAR/devel 2436413 Merge pull request NCAR#6 from NCAR-CISL-ASAP/devel 2125a4f Merge pull request NCAR#4 from NCAR-CISL-ASAP/devel c51daf1 Merge pull request NCAR#1 from NCAR-CISL-ASAP/devel git-subtree-dir: averager/pyAverager git-subtree-split: 018f31ff4013fa0b240470003f27025811aeaf11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keith Oleson's bug fix to lnd_diag/shared/lnd_func.ncl
Test suite:
Fixes [Github issue #]: N/A
User interface changes: none
Input data changes: none
Code review: Keith Oleson