Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer description to layer modal #955

Merged
merged 2 commits into from
May 17, 2024
Merged

Add layer description to layer modal #955

merged 2 commits into from
May 17, 2024

Conversation

hanbyul-here
Copy link
Collaborator

Related Ticket: #912

Description of Changes

Add Layer description to the modal

Notes & Questions About Changes

I don't think they look the best now (layer one liner and descriptions are not getting differentiated.) hoping to get @faustoperez 's opinion on it.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 32ba49d
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66464cdad8855d0008501011
😎 Deploy Preview https://deploy-preview-955--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link

@faustoperez faustoperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, left a design for minor styling at #912

@hanbyul-here hanbyul-here merged commit bac2b5d into main May 17, 2024
8 checks passed
@hanbyul-here hanbyul-here deleted the 912-layer-desc branch May 17, 2024 13:13
hanbyul-here added a commit that referenced this pull request May 23, 2024
## What's Changed
We are bumping the major version up since it won't be compatible with
the previous version of UI with the bumped up Node version

## 🎉 Features
- Update Node Version to v20 in
#917 ,
#971

## 🚀 Improvements
- Replace old map component with new map component in Story Maps in
#827
- Data Catalog Feature Component Breakout in
#946
- Add layer description to layer modal in
#955
- 
## 🐛 Fixes
🦗
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants