Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E & A] Add layer description to layer info modal #912

Closed
1 task
j08lue opened this issue Apr 3, 2024 · 4 comments
Closed
1 task

[E & A] Add layer description to layer info modal #912

j08lue opened this issue Apr 3, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@j08lue
Copy link
Contributor

j08lue commented Apr 3, 2024

https://github.com/US-GHG-Center/veda-config-ghg/blob/077c3e8fd5ec7af99287106c58afa16dad7d1593/datasets/casagfed-carbonflux-monthgrid-v3.data.mdx?plain=1#L41

We would probably want to put that right underneath the layer title or underneath the short info pills (units etc). We can try both in a PR and decide on what looks best, or @faustoperez can advise.

Acceptance criteria

  • Layer info modal in E&A shows the layer description
@Jeanne-le-Roux
Copy link

Just a note (from GHG Center perspective) that of the E&A improvements, I think this should be first priority - one of our data providers from the EPA noticed that the layer descriptions were missing during testing & requested they be added

@faustoperez
Copy link

faustoperez commented May 13, 2024

@hanbyul-here @sandrahoang686 please advise if this is possible, design wise it's a simple task.

@hanbyul-here
Copy link
Collaborator

@faustoperez Yes, I don't see any challenges in the implementation of this feature. I will make a change following @j08lue 's first description and we can take it from there if any revision is necessary.

@faustoperez
Copy link

faustoperez commented May 15, 2024

hanbyul-here added a commit that referenced this issue May 17, 2024
**Related Ticket:** #912 

### Description of Changes
Add Layer description to the modal

### Notes & Questions About Changes
I don't think they look the best now (layer one liner and descriptions
are not getting differentiated.) hoping to get @faustoperez 's opinion
on it.
@j08lue j08lue closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants