Update Node Version #917
Merged
Update Node Version #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
oh no, I can't tag @sandrahoang686 as a reviewer- I should have just made a new PR. Can both of you @sandrahoang686 @dzole0311 try out if you see any unexpected problem, how it works with the dashboard instances? |
dzole0311
reviewed
May 21, 2024
There was a problem hiding this comment.
@hanbyul-here I tested the change across the three instances locally and saw no regressions (but had to bump both the instance and the git submodule versions of Node). After merging this, I guess we will follow-up with PRs to bump up the version across the three instances (veda-config, veda-config-ghg and veda-config-eis) as well?
dzole0311
approved these changes
May 21, 2024
This was referenced May 21, 2024
Merged
hanbyul-here
added a commit
that referenced
this pull request
May 23, 2024
**Related Ticket:** #947 follow up of #917 ### Description of Changes I realized that it is better to make the Node version flexible in package.json, so VEDA-UI users don't have to be on exact Node v20. ### Notes & Questions About Changes I think v18 is a reasonable choice to be the minimum version number since 1. We don't have a package that requires specific Node version and 2. 18 is the actively maintained Node at this point (https://nodejs.org/en/about/previous-releases) 🤔 Is there any more thing to consider?
hanbyul-here
added a commit
that referenced
this pull request
May 23, 2024
## What's Changed We are bumping the major version up since it won't be compatible with the previous version of UI with the bumped up Node version ## 🎉 Features - Update Node Version to v20 in #917 , #971 ## 🚀 Improvements - Replace old map component with new map component in Story Maps in #827 - Data Catalog Feature Component Breakout in #946 - Add layer description to layer modal in #955 - ## 🐛 Fixes 🦗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I (@hanbyul-here ) took this PR over from @sandrahoang686
Related Ticket: #947
Description of Changes
Update Node to v20.
Notes & Questions About Changes
I will sit this PR until the currently active PR is getting merged, (I can see that Netlify will act out changing the Node versions between previews)
Validation / Testing
There should not be any noticable changes.