Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linters and dev tools to match Core #241

Closed
MJJoyce opened this issue Dec 14, 2022 · 1 comment · Fixed by #250
Closed

Add linters and dev tools to match Core #241

MJJoyce opened this issue Dec 14, 2022 · 1 comment · Fixed by #250
Assignees
@MJJoyce

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Dec 14, 2022

Update GUI with the same development support tooling currently used in Core. We'll need to update the README with instructions on how to use these as well.
@MJJoyce MJJoyce self-assigned this Dec 14, 2022
@MJJoyce
Copy link
Member Author

MJJoyce commented Dec 15, 2022

Related to #231

MJJoyce added a commit that referenced this issue Jan 19, 2023
@MJJoyce
Issue #241 - Add linters and checks to match Core
dfb278b 
Add devel dependencies, linters, and check pipeline to match Core. This
currently includes black, mypy, flake8, and other pre-commit pipelines.
MJJoyce added a commit that referenced this issue Jan 19, 2023
@MJJoyce
Issue #241 - Linter compliance updates
12d5a19 
Various minor code updates to keep mypy and other linters happy. Note,
some of the mypy errors required minor updates in core so type checking
could be run. Changes will be pushed to Core to address that separately.
MJJoyce added a commit that referenced this issue Jan 19, 2023
@MJJoyce
Issue #241 - Add tox config and update gitignore
92554f1 
Add stripped down version of tox config from Core. This has
python-version specific testing removed since we don't have a test suite
(in python) to exercise stuff.

Note, the tox runs won't work currently due to required changes that are
pending in other PRs.
MJJoyce added a commit that referenced this issue Jan 19, 2023
@MJJoyce
Issue #241 - Update README with dev tool related updates
a2562c1
This was referenced Jan 19, 2023
Merged
Closed
MJJoyce added a commit that referenced this issue Jul 26, 2023
@MJJoyce
Issue #241 - Add linters and checks to match Core
cd00594 
Add devel dependencies, linters, and check pipeline to match Core. This
currently includes black, mypy, flake8, and other pre-commit pipelines.
MJJoyce added a commit that referenced this issue Jul 26, 2023
@MJJoyce
Issue #241 - Linter compliance updates
cf6865e 
Various minor code updates to keep mypy and other linters happy. Note,
some of the mypy errors required minor updates in core so type checking
could be run. Changes will be pushed to Core to address that separately.
MJJoyce added a commit that referenced this issue Jul 26, 2023
@MJJoyce
Issue #241 - Add tox config and update gitignore
a35a02e 
Add stripped down version of tox config from Core. This has
python-version specific testing removed since we don't have a test suite
(in python) to exercise stuff.

Note, the tox runs won't work currently due to required changes that are
pending in other PRs.
MJJoyce added a commit that referenced this issue Jul 26, 2023
@MJJoyce
Issue #241 - Update README with dev tool related updates
2be208c
MJJoyce added a commit that referenced this issue Jul 26, 2023
@MJJoyce
Merge pull request #250 from NASA-AMMOS/issue-241
0c08275 
Issue #241 - Add linters and dev tools to match Core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJJoyce MJJoyce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #241 - Add linters and dev tools to match Core NASA-AMMOS/AIT-GUI
1 participant
@MJJoyce