Issue #241 - Add linters and dev tools to match Core #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add devel dependencies, linters, and check pipeline to match Core. This currently includes black, mypy, flake8, and other pre-commit pipelines.
Various minor code updates to keep mypy and other linters happy. Note, some of the mypy errors required minor updates in core so type checking could be run. Changes will be pushed to Core to address that separately.
Add stripped down version of tox config from Core. This has python-version specific testing removed since we don't have a test suite (in python) to exercise stuff. Note, the tox runs won't work currently due to required changes that are pending in other PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add devel dependencies, linters, and check pipeline to match Core. This
currently includes black, mypy, flake8, and other pre-commit pipelines.
Various minor code updates to keep mypy and other linters happy. Note,
some of the mypy errors required minor updates in core so type checking
would pass. Changes will be pushed to Core to address that separately.
Add stripped down version of tox config from Core. This has
python-version specific testing removed since we don't have a test suite
(in python) to exercise stuff.
Note, the tox runs won't work currently due to required changes that are
pending in other PRs.
Resolve #241