Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger type annotations for GUI checks #491

Closed
MJJoyce opened this issue Jan 19, 2023 · 0 comments · Fixed by #492
Closed

Add logger type annotations for GUI checks #491

MJJoyce opened this issue Jan 19, 2023 · 0 comments · Fixed by #492

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Jan 19, 2023

When making updates for NASA-AMMOS/AIT-GUI#241 I needed to add a few type annotations to log.py globals to keep mypy happy.
MJJoyce added a commit that referenced this issue Jan 19, 2023
@MJJoyce
Issue #491 - Add logger type annotations for GUI mypy checks
d082c05 
Add minor type annotations in log.py to keep type checking happing in
AIT-GUI.

Resolve #491
@MJJoyce MJJoyce mentioned this issue Jan 19, 2023
Merged
MJJoyce added a commit that referenced this issue Jan 24, 2023
@MJJoyce
Issue #491 - Add logger type annotations for GUI mypy checks
1d08061 
Add minor type annotations in log.py to keep type checking happy in
AIT-GUI.

Resolve #491
MJJoyce added a commit that referenced this issue Jan 24, 2023
@MJJoyce
Issue #491 - Move logger globals for Python bug
0ec069a 
Shift the `log.py` logger globals to the beginning of the file to avoid
a Python bug that causes spurious "annotated name can't be global"
errors when mypy lints the files.

See here for the issue report:
https://bugs.python.org/issue34939

Clarification on the ticket marks this as a bug and a fix was added.
This avoids the error in Python 3.7.
MJJoyce added a commit that referenced this issue Jan 24, 2023
@MJJoyce
Issue #491 - Add logger type annotations for GUI mypy checks
63720ff 
Add minor type annotations in log.py to keep type checking happy in
AIT-GUI.

Resolve #491
MJJoyce added a commit that referenced this issue Jan 24, 2023
@MJJoyce
Issue #491 - Move logger globals for Python bug
74f9778 
Shift the `log.py` logger globals to the beginning of the file to avoid
a Python bug that causes spurious "annotated name can't be global"
errors when mypy lints the files.

See here for the issue report:
https://bugs.python.org/issue34939

Clarification on the ticket marks this as a bug and a fix was added.
This avoids the error in Python 3.7.
MJJoyce added a commit that referenced this issue Jan 24, 2023
@MJJoyce
Merge pull request #492 from NASA-AMMOS/issue-491
1ae8173 
Issue #491 - Add logger type annotations for GUI mypy checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #491 - Add logger type annotations for GUI mypy checks NASA-AMMOS/AIT-Core
1 participant
@MJJoyce