Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Test cases for QANet #10067

Closed
6 tasks done
aneesharaines opened this issue Jan 24, 2022 · 3 comments
Closed
6 tasks done

Remaining Test cases for QANet #10067

aneesharaines opened this issue Jan 24, 2022 · 3 comments

Comments

@aneesharaines
Copy link
Contributor

aneesharaines commented Jan 24, 2022

  • Payments + snapp transactions from the same account are accepted
  • A Snapp that's guaranteed to fail
  • Txns with multiple proofs
  • Update all the fields in one txn
  • transactions are ordered fee per weight unit
  • Max transactions per block
@psteckler
Copy link
Member

psteckler commented Feb 9, 2022

Note: currently, we can't use the parties in a snapp as sender or receiver in a payment, so the test uses separate accounts for the payment. That will change eventually, and the test can be updated to use the parties accounts in the payment.

Matthew says: For that check, it appears that we need to update the old txn logic to check the permissions for sending/receiving and delegating, then it can be removed. (The old txns must not be able to exfiltrate funds from an account where send: Proof in the permissions.)

@deepthiskumar
Copy link
Member

deepthiskumar commented Feb 11, 2022

Suggest adding a test that check snark work is happening for snapp transactions. This might be higher priority than
the tests for Transactions are ordered fee per weight unit and Max transactions per block

Steps in the test:

  1. Send a valid snapp transaction
  2. send payments.
  3. Wait for snarked ledger hash in the protocol state to change. (probably worth waiting for two ledger hash change to ensure snapps are in it)

Also, create a different profile for this test that uses a smaller scan state src/config/scan_state/small.mlh than what's in integration_tests.mlh. With this config and15-20 transactions, the snarked ledger hash should change at least twice

@psteckler
Copy link
Member

All the checklist items are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants