Remove snapps-generated integration test; add intentionally failing snapps to snapps test #10341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
added
ci-build-me
psteckler
force-pushed
the
feature/verify-perms-updates-snapps-generated
branch
from
b64f206 to
501744c
Compare
psteckler
force-pushed
the
feature/verify-perms-updates-snapps-generated
branch
from
501744c to
3c27d6c
Compare
psteckler
changed the title
psteckler
added
the
ci-build-me
QuiteStochastic
approved these changes
Mar 3, 2022
lk86
approved these changes
Mar 3, 2022
deepthiskumar
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
snapps-generatedtest, which was broken beyond simple repair. TheParties.tcontained keys in the integration test ledger, but those weren't snapp accounts. The updates in the snapp were not being applied, though there was no indication of error.Rename the
snapps-constructedtest to justsnapps, and add a couple of snapps meant to fail (an invalid nonce and an invalid signature).Part of #10067.