Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapp integration test #10120

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

psteckler
Copy link
Member

@psteckler psteckler commented Jan 28, 2022

Create an integration test for snapps.

Strategy:

  • generate a Parties.t using QC generators
  • integration test ledgers have a snapp field
  • substitute fee payer key from an account in the integration test ledger
  • substitute a dummy signature for the fee payer, so the snapp is expected to fail

Other changes:

  • add a new GraphQL endpoint sendTestSnapp that accepts a scalar, so programatically, we can just send a Yojson.Basic.t; the extant sendSnapp requires an OCaml object ; the upcoming derivers may make this extra endpoint unnecessary
  • the length check on token symbols updated to use nonstrict inequality
  • define snapp_to_be_included_in_frontier for future tests
  • disable profile_constraints in Pickles due to an exception opening a log file; added a close for that file, which didn't help

Part of #10067.

@psteckler psteckler added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jan 28, 2022
@psteckler psteckler force-pushed the feature/snapp-integration-test branch from 6a7cf70 to 7cbe457 Compare February 2, 2022 00:35
@psteckler psteckler force-pushed the feature/snapp-integration-test branch from ecf8caa to 91683cc Compare February 2, 2022 22:50
@psteckler psteckler changed the title [DO NOT MERGE] Snapp integration tests Snapp integration test Feb 2, 2022
@psteckler psteckler marked this pull request as ready for review February 2, 2022 23:37
@psteckler psteckler requested review from a team as code owners February 2, 2022 23:37
@mrmr1993 mrmr1993 merged commit ce068a6 into feature/snapps-protocol Feb 3, 2022
@mrmr1993 mrmr1993 deleted the feature/snapp-integration-test branch February 3, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants