Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test using constructed Snapps #10266

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Integration test using constructed Snapps #10266

merged 4 commits into from
Feb 22, 2022

Conversation

psteckler
Copy link
Member

@psteckler psteckler commented Feb 18, 2022 •
edited
Loading

Integration test with two snapps: The first creates a snapps account, the next updates that account's snapp state.

The snapps are sent via GraphQL. For each, the test waits until the snapp is included in the transition frontier.

Also, renamed Signed_command_memo.to_string to to_base58_check, similarly for of_string.

Part of #10067.

@psteckler psteckler added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 18, 2022
@psteckler psteckler force-pushed the feature/constructed-snapps-integration-test branch from 070e6f2 to 097523a Compare February 19, 2022 00:02
@psteckler psteckler changed the title [DO NOT MERGE] Integration test using constructed Snapps Integration test using constructed Snapps Feb 19, 2022
@psteckler psteckler marked this pull request as ready for review February 19, 2022 00:05
@psteckler psteckler requested review from a team as code owners February 19, 2022 00:05
bkase
bkase approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product review ✅

@psteckler psteckler merged commit 5997dd3 into develop Feb 22, 2022
@psteckler psteckler deleted the feature/constructed-snapps-integration-test branch February 22, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkase bkase bkase approved these changes

@deepthiskumar deepthiskumar deepthiskumar approved these changes

@samuelarogbonlo samuelarogbonlo samuelarogbonlo approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psteckler @bkase @deepthiskumar @samuelarogbonlo