Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | NZBGet: Migrate to new project maintainer #6752

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

Joulinar
Copy link
Collaborator

@Joulinar Joulinar marked this pull request as draft November 15, 2023 11:02
@Joulinar Joulinar self-assigned this Nov 15, 2023
@Joulinar Joulinar added this to the v8.24 milestone Nov 15, 2023
@Joulinar
Copy link
Collaborator Author

ok download URL not working yet and they don't support CPU architecture (aarch64) as of now. Therefore keeping this in draft for now.

@MichaIng
Copy link
Owner

We could pull them directly from GitHub, using the common api.github.com method: https://github.com/nzbgetcom/nzbget/releases

This is also where the download links on their website are pointing to, only their docs are currently wrong 😄.

@MichaIng
Copy link
Owner

MichaIng commented Nov 16, 2023

I just asked about aarch64. I do not see many changes on the previous build scripts, so it should just work as before and should be hence trivial to re-add the arch to CI builds: nzbgetcom/nzbget#57

EDIT: Will be added 🙂.

@MichaIng
Copy link
Owner

MichaIng commented Nov 20, 2023

Seems to work well now: https://github.com/MichaIng/DietPi/actions/runs/6932552257

I also switched form log file to journal logging the process in foreground (within the systemd service). The nzbget.com download URL btw seems to be a docs bug, so it seems to be not intended to keep that one, so that we need to use the GitHub API.

ToDo:

  • Changelog entry
  • Patch on next DietPi update to switch to journal logging, probably best via reinstall, adjusting the log file prior to reinstall (as it is otherwise skipped).
  • Review the other settings. Especially the cipher suite is likely outdated and should better not be touched.
  • Update docs page: Update NZBGet docs DietPi-Docs#951

@MichaIng MichaIng changed the title DietPi-Software | NZBGet DietPi-Software | NZBGet: Migrate to new project maintainer Nov 20, 2023
@Joulinar
Copy link
Collaborator Author

I see they added arm64 support recently

@MichaIng
Copy link
Owner

Yes, I pushed that a little since it seemed simple, given that aarch64 was previously supported and is hence part of the build scripts already. He even backported the build into the current release 🙂.

@Joulinar
Copy link
Collaborator Author

Ok I might be able to test on RPI4 later the evening

@MichaIng
Copy link
Owner

No stress, I tested via GitHub and on NanoPi R4S, with the new (main branch) and 22.0 builds, all working perfectly fine.

@MichaIng
Copy link
Owner

MichaIng commented Dec 7, 2023

Docs PR up: MichaIng/DietPi-Docs#957
Upgrade and reinstall works fine.

DietPi-Software | NZBGet: Update of the download URL due to a new project maintainer and switch to journal log
@MichaIng MichaIng merged commit d41e825 into dev Dec 7, 2023
2 checks passed
@MichaIng MichaIng deleted the NZBGet branch December 7, 2023 20:15
StephanStS added a commit to MichaIng/DietPi-Docs that referenced this pull request Dec 15, 2023
* NZBGet | All logs are done to journal now

MichaIng/DietPi#6752

* Update bittorrent.md

---------

Co-authored-by: StephanStS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants