Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 builds to CI #57

Closed
MichaIng opened this issue Nov 16, 2023 · 6 comments
Closed

Add aarch64 builds to CI #57

MichaIng opened this issue Nov 16, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@MichaIng
Copy link

Is there a particular reason why aarch64 binaries are not built? As far as I can see, the build scripts do still support it, so it might be possible to just add it here: https://github.com/nzbgetcom/nzbget/blob/develop/.github/workflows/linux.yml#L26

But the build-nzbget-ci.sh is not public, so not sure whether it is an entirely different script.

@phnzb
Copy link
Collaborator

phnzb commented Nov 16, 2023

I can try building it, but I'll need someone's help testing it

@MichaIng
Copy link
Author

That would be great, I can test it.

@phnzb
Copy link
Collaborator

phnzb commented Nov 17, 2023

@MichaIng I have successfully build aarch64 toolchain and nzbget for this architecture. Please try to test aarch64 build from this workflow artifacts.If everything is ok, we will add aarch64 to the CI builds.

@MichaIng
Copy link
Author

Works like a charm, tested on NanoPi R4S. Many thanks for adding it so quickly 🚀.

@phnzb
Copy link
Collaborator

phnzb commented Nov 20, 2023

@MichaIng PR with added aarch64 builds was merged into develop #61 . Next linux CI builds will contain aarch64 architecture. Also, 22.0 release was updated with linux builds with aarch64 support. Please test if possible.

@luckedea luckedea added the enhancement New feature or request label Nov 20, 2023
@MichaIng
Copy link
Author

Works very well with the 22.0 release. Here a test install in GitHub actions, within QEMU-emulated container: https://github.com/MichaIng/DietPi/actions/runs/6932552257/job/18856975756#step:2:655
Some lines down the output, it is also tested whether the service is running and the expected TCP port ist listened to.

This includes already running it via systemd service with -so OutputMode=log 🙂.

I also did another successful test install on the NanoPi R4S.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants