Release v6.25 #2950
Merged
Release v6.25 #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into dietpi-services_v2
+ DietPi-Globals | G_DIETPI-NOTIFY -2: Little performance boost by replacing external tput command with internal echo code, where possible. And mawk is faster than sed! "shopt -s extglob" allows bash string manipulation with extended regex, e.g. "var=${var//\\e[[0-9]*([;0-9])m/}" (for colour code removal), but interestingly it is much slower than set/mawk if the string is a bid longer and has more than one match. So pure bash string manipulation is only beneficial for simple glob patterns, but there it is orders of magnitude faster.
+ Interesting find: "${array[i]}" works without "$" (if "i" is an integer), however we stay with explicit variable calls.
+ DietPi-Launcher | Syntax + DietPi-Launcher | Do not run G_INIT(): Concurrency tests are done by the target scripts, no tmp files are created, no locale critical command output scraped and it makes sense to start target scripts with fresh $HIERARCHY in this case. Leave root user and rootfs R/W check in place, even that this is checked within target scripts: All target scripts require root permissions and most rootfs R/W and the effort of going back and forth is higher than having the abortion directly at launcher start.
- DietPi-Software | MPD: Resolved a systemd warning about invalid RuntimeDirectory value: - Jessie: [/lib/systemd/system/mpd.service:11] Runtime directory is not valid, ignoring assignment: /run/mpd - Stretch: [/lib/systemd/system/mpd.service:11] Runtime directory is not valid, ignoring assignment: /run/mpd - Buster: /lib/systemd/system/mpd.service:9: RuntimeDirectory= path is absolute, ignoring: /run/mpd - Path must be related, as it is always created beneath /run/: https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectory= - Setting it to "mpd" works well on Stretch and Buster, but on Jessie: Failed at step RUNTIME_DIRECTORY spawning /usr/bin/mpd: File exists - Neither the APT package systemd unit nor the upsteam one have the RuntimeDirectory defined. It defaults to /run/<service_name> and is successfully created and used if not defined. Removing the line works well on all three distro versions.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v6.25
(03/07/19)
Changes / Improvements / Optimisations
Bug Fixes
As always, many smaller code performance and stability improvements, visual and spelling fixes have been done, too much to list all of them here. Check out all code changes of this release on GitHub: #2950
Known/Outstanding Issues
For all additional issues that may appear after release, please see the following link for active tickets: https://github.com/MichaIng/DietPi/issues