Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Software | Docker: Installer does not yet support Buster #2891

Closed
Qarasique opened this issue Jun 5, 2019 · 3 comments
Closed

DietPi-Software | Docker: Installer does not yet support Buster #2891

Qarasique opened this issue Jun 5, 2019 · 3 comments
Labels
Buster External bug 🐞 For bugs which are not caused by DietPi. Solution available 🥂 Definite solution has been done
Milestone

Comments

@Qarasique
Copy link

Qarasique commented Jun 5, 2019

ADMIN EDIT

Workaround after dietpi-software has finished:

sed -i 's/10/buster/' /etc/apt/sources.list.d/docker.list
G_AGUP
G_AGI docker-ce docker-ce-cli

Creating a bug report/issue

Required Information

  • DietPi version |
    G_DIETPI_VERSION_CORE=6
    G_DIETPI_VERSION_SUB=24
    G_DIETPI_VERSION_RC=1
    G_GITBRANCH='master'
    G_GITOWNER='MichaIng'
  • Distro version | buster/sid
  • Kernel version | 4.19.42-v7+ General | Update VM images to Stretch #1219 SMP Tue May 14 21:20:58 BST 2019 armv7l GNU/Linux
  • SBC device | RPi 3 Model B+ (armv7l)
  • Power supply used | 5V2A
  • SDcard used | 32gb Sony

Additional Information (if applicable)

  • Software title | Docker
  • Was the software title installed freshly or updated/migrated - Freshly
  • Can this issue be replicated on a fresh installation of DietPi - Yes

Steps to reproduce

  1. ... Install docker on fresh machine through Dietpi-launcher

Expected behaviour

  • Docker just works

Actual behaviour

Extra details

  • Docker partly install but 'docker' command dont work, so it cant install without files from his repo
@MichaIng
Copy link
Owner

MichaIng commented Jun 5, 2019

@Qarasique
Many thanks for your report. Will run some test on Debian Buster to see if it's an RPi-only issue or even kernel-related.

@MichaIng MichaIng added External bug 🐞 For bugs which are not caused by DietPi. Raspberry Pi Buster labels Jun 5, 2019
@MichaIng
Copy link
Owner

MichaIng commented Jun 15, 2019

Verified it's a bug with Buster of the official https://get.docker.com/ installer script. (or lets say the script simply does not support Buster yet)

		debian|raspbian)
			dist_version="$(sed 's/\/.*//' /etc/debian_version | sed 's/\..*//')"
			case "$dist_version" in
				9)
					dist_version="stretch"
				;;
				8)
					dist_version="jessie"
				;;
			esac
		;;

What needs to be added:

				10)
					dist_version="buster"
				;;

You can easily fix it:

sed -i 's/10/buster/' /etc/apt/sources.list.d/docker.list
G_AGUP
G_AGI docker-ce docker-ce-cli

I opened a PR on Docker GitHub: docker/docker-install#126
Waiting for user reply = "Waiting for above PR to be merged"

If this is not the case until v6.25 release, I will implement the above workaround into our install code.

@MichaIng MichaIng added Workaround available 🆗 Workaround is available/has been implemented, but a definite solution should be found when possible. Waiting for user reply ⏳ labels Jun 15, 2019
@MichaIng MichaIng changed the title Docker Buster cant install on buster DietPi-Software | Docker: Installer does not yet support Buster Jun 15, 2019
@MichaIng MichaIng added Solution available 🥂 Definite solution has been done and removed Waiting for user reply ⏳ Workaround available 🆗 Workaround is available/has been implemented, but a definite solution should be found when possible. labels Jul 1, 2019
@MichaIng MichaIng added this to the v6.25 milestone Jul 1, 2019
@MichaIng
Copy link
Owner

MichaIng commented Jul 1, 2019

PR has been merged, Debian Buster will work now and I just added a workaround for Raspbian Buster, as there is no branch yet for it in the Docker repo: 093ca14
Changelog: c82bd35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buster External bug 🐞 For bugs which are not caused by DietPi. Solution available 🥂 Definite solution has been done
Projects
None yet
Development

No branches or pull requests

2 participants