-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DietPi-Software | Redis: Minor un/installation/activation fixes of PHP module #1249
Merged
+9
−4
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
DietPi-Software | Redis: Minor un/installation and activation fixes o…
…f PHP module - Auto installation of PHP module, if PHP stack is installed. Just do this, if PHP state is already installed+configured, otherwise this leads to dependency PHP installations. If PHP install state == 1, then redis module will be installed together with PHP already. - Correctly use the phpenmod command to activate the PHP module. Otherwise this command will show errors later, I even got empty .ini files, leading to inactive module. - Uninstall PHP module together with redis-server.
commit 8f180a95fe231b4421ba06d7b0cce06d4bb5e741
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only be true, if
dietpi-software
has previously installed89
and rebooted.=2
is not set until the very end of dietpi-software installs:https://github.com/Fourdee/DietPi/blob/testing/dietpi/dietpi-software#L14286-L14296
=1
during installations,=2
set at the very end.Is this by intention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is okay: if redis and php were chosen to install together, php part includes installation of php(5)-redis anyway.
This was just necessary, if php was already installed before and you somehow chose to install redis-server later, e.g. you read about advantages with ownCloud/Nextcloud 😉.
The problem with using ">=1" is, as I tried to explain in code, that redis-server package installation is done before PHP, and as php-redis depends on php packages, it will install them and in case choose some random optional dependency (libapache-mod-php / php-fpm / php-cgi e.g.): https://packages.debian.org/stretch/php-redis
We could switch positions of redis and php installation as another solution. Generally there would be the same problem then with php-redis' server dependency, but redis-server is so far just suggestion, not dependency: https://packages.debian.org/jessie/php5-redis
Long story short: On choosing redis (==1), it will install the module, if php==2 and if php==1 then php loop will see redis==1 and take care it's module installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaIng
Thanks , understood 👍
I'll get this merged.