DietPi-Software | Redis: Minor un/installation/activation fixes of PHP module #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MichaIng
commented
Nov 21, 2017
MichaIng
commented
- Auto installation of PHP module, if PHP stack is installed. Just do this, if PHP state == 2, otherwise this leads to dependency PHP installations. If PHP install state == 1, then redis module will be installed together with PHP afterwards.
- Correctly use the phpenmod command to activate the PHP module. Otherwise this command will show errors later, I even got empty .ini files, leading to inactive module.
- Uninstall PHP module together with redis-server.
…f PHP module - Auto installation of PHP module, if PHP stack is installed. Just do this, if PHP state is already installed+configured, otherwise this leads to dependency PHP installations. If PHP install state == 1, then redis module will be installed together with PHP already. - Correctly use the phpenmod command to activate the PHP module. Otherwise this command will show errors later, I even got empty .ini files, leading to inactive module. - Uninstall PHP module together with redis-server.
Fourdee
reviewed
Nov 21, 2017
| @@ -3795,6 +3795,12 @@ _EOF_ | |||
|
|
|||
| Banner_Installing | |||
| AGI redis-server | |||
| #Redis php module | == 2 to check for existing installs, if == 1, then module will be installed together with PHP, to prevent dependency installations | |||
| if (( ${aSOFTWARE_INSTALL_STATE[89]} == 2 )); then | |||
There was a problem hiding this comment.
This will only be true, if dietpi-software has previously installed 89 and rebooted.
=2 is not set until the very end of dietpi-software installs:
https://github.com/Fourdee/DietPi/blob/testing/dietpi/dietpi-software#L14286-L14296
=1 during installations, =2 set at the very end.
Is this by intention?
There was a problem hiding this comment.
Yes this is okay: if redis and php were chosen to install together, php part includes installation of php(5)-redis anyway.
This was just necessary, if php was already installed before and you somehow chose to install redis-server later, e.g. you read about advantages with ownCloud/Nextcloud 😉.
The problem with using ">=1" is, as I tried to explain in code, that redis-server package installation is done before PHP, and as php-redis depends on php packages, it will install them and in case choose some random optional dependency (libapache-mod-php / php-fpm / php-cgi e.g.): https://packages.debian.org/stretch/php-redis
We could switch positions of redis and php installation as another solution. Generally there would be the same problem then with php-redis' server dependency, but redis-server is so far just suggestion, not dependency: https://packages.debian.org/jessie/php5-redis
Long story short: On choosing redis (==1), it will install the module, if php==2 and if php==1 then php loop will see redis==1 and take care it's module installation.
There was a problem hiding this comment.
Fourdee
referenced
this pull request
Nov 22, 2017
+ DietPi-Software | Redis: Minor un/installation/activation fixes of PHP module (Thanks to @MichaIng) : https://github.com/Fourdee/DietPi/pull/1249
Merged
Fourdee
referenced
this pull request
Dec 10, 2017
**v159** (10/11/17) **Image Modifications:** VMWare | Updated to Debian Stretch: https://github.com/Fourdee/DietPi/issues/1219 VirtualBox | Updated to Debian Stretch, many thanks @MichaIng: https://github.com/Fourdee/DietPi/issues/1219 RPi | Updated to Debian Stretch: https://github.com/Fourdee/DietPi/issues/475 **Changes / Improvements / Optimizations:** General | Odroid XU3/4 images updated: Includes kernel support for EMMC 5.1 (thanks Meveric): https://github.com/Fourdee/DietPi/issues/1252 General | DietPi RPi kernel: Updated to 4.9.62. General | DietPi RPi kernel: Will no longer re-install, if the current version is already at latest. General | Added farenheit readouts for cpu_info and dietpi-config. For those "over the pond" :D : http://dietpi.com/phpbb/viewtopic.php?f=12&t=2516&p=9772#p9772 General | Sparky SBC: Kernel update to add support for USB 1.1 DACs, thanks @sudeep. This must be enabled manually, if using a USB 1.1 DAC, as this breaks Allo WiFi dongle. Edit "/DietPi/uEnv.txt" and change the value "aotg.aotg1_speed=1" (from "0"), then reboot. General | We now define a default LD_LIBRARY_PATH for all systems, exported from /etc/bash.bashrc: https://github.com/Fourdee/DietPi/issues/475#issuecomment-350380744 DietPi-Services | Run "dietpi-services help" to see a full list of updated commands: Added support for "enable" and "disable". "disable" will stop and disable the service and prevent it from running, "enable" will enable and start the service. EG: "dietpi-services disable cron", will prevent Cron from starting. Added support for start/stop/restart a single service (eg: dietpi-services stop apache2). This is basically a symlink to systemD: https://github.com/Fourdee/DietPi/issues/1114 DietPi-Config | WiFi: Now uses the wpa_supplicant.conf method to setup WiFi connections. WEP is no longer supported by DietPi in this mode. WPA-PSK/WPA2-PSK and OPEN hosts supported: https://github.com/Fourdee/DietPi/issues/1262 DietPi-Backup | "Full Backup" Mode is now the default for fresh DietPi installations. This is mainly due to MySQL data now being in the DietPi userdata directory. DietPi-Config | Tools > Benchmarks: Added ability to benchmark CPU performance based on bash + integer: https://github.com/Fourdee/DietPi/issues/1253#issuecomment-346881878 DietPi-Config | Time sync modes: NTP is now uninstalled when SystemD timedatectl is enabled. Reinstalled on demand. Timedatectl pool servers are now also set: https://github.com/Fourdee/DietPi/issues/1208#issuecomment-343762480 DietPi-Software | First run setup, now logged to /etc/dietpi/logs/dietpi-firstrun-setup.log. DietPi-Software | APT log: Moved to /etc/dietpi/logs/dietpi-software_apt.log, to prevent RAMlog clearing log during automated installations. DietPi-Software | MPD (Stretch): Install updated to 0.20.11. Also supports native DSD playback (thanks to @sudeep and PJotr), when "Native" output freq/bit is set: https://github.com/Fourdee/DietPi/issues/1236 DietPi-Software | moOde: MPD now installed via pre-built binaries. Will reduce install time: https://github.com/Fourdee/DietPi/issues/1223#issuecomment-345265290 DietPi-Software | Nextcloud: Correct database access issue for MariaDB + minor fixes: https://github.com/Fourdee/DietPi/pull/1242 DietPi-Software | ownCloud: Installation fixed, respecting different distro repos: https://github.com/Fourdee/DietPi/pull/1243 DietPi-Software | MPD (inc YMPD/O!MPD): Default data directory is now "/mnt", this will include all USB drives and network locations: https://github.com/Fourdee/DietPi/issues/1202 DietPi-Software | Mopidy: Default data directory is now "/mnt", this will include all USB drives and network locations. DietPi-Software | Syncthing: Installation updated to version 0.14.40, for new installations only. Removal of inotify (now included in main syncthing): https://github.com/Fourdee/DietPi/issues/1260 DietPi-Software | Node-Red: Symlink created during install from ~/.node-red to DietPi user data dir: https://github.com/Fourdee/DietPi/issues/1256 DietPi-Software | YMPD: Fixed Stretch installation + Now available for all CPU archs + Upgraded to SystemD service: https://github.com/Fourdee/DietPi/issues/475 DietPi-Software | Gitea: Install updated to 1.3.1 (for new installations only). Added support for ARMv8. Now installed to /mnt/dietpi_userdata/gitea, runs as dietpi user: https://github.com/Fourdee/DietPi/issues/686 http://dietpi.com/phpbb/viewtopic.php?f=8&t=5&p=9863#p9863 **Bug Fixes:** DietPi-Automation | Resolved an issue where SSH server choice, was not installing selected choice: https://github.com/Fourdee/DietPi/issues/1122 DietPi-Config | Nvidia driver: nouveau now disabled by default on x86_64, fix for 750Ti and possibily other Nvidia chipsets (thanks dubyazero): https://github.com/Fourdee/DietPi/issues/1244 DietPi-Config | RPi Stretch: Resolved an issue with onboard Wifi failing to scan: https://github.com/Fourdee/DietPi/issues/1262 DietPi-Config | RAM Benchmark: Resolved an issue where devices without /tmp mounted to tmpfs would fail the test. We now check for this mount, prior to allowing the test to run: https://github.com/Fourdee/DietPi/issues/1130#issuecomment-350114298 DietPi-Software | Pi-Hole: Resolved various issues with this installation. DietPi will now also detect a failed Pi-Hole script exit and flag as not installed. : https://github.com/Fourdee/DietPi/issues/1282#issuecomment-350490524 DietPi-Software | Redis: Minor un/installation/activation fixes of PHP module (Thanks to @MichaIng) : https://github.com/Fourdee/DietPi/pull/1249 DietPi-Software | moOde: Resolved an issue where dietpi-drive_manager mounted drives, would not be available in the libary: https://github.com/Fourdee/DietPi/issues/1223#issuecomment-346708298 DietPi-Software | PHP: Solve 'upload_tmp_dir' issue, if PHP service uses 'PrivateTmp': https://github.com/Fourdee/DietPi/issues/1144 DietPi-Software | Syncthing: Resolved a permissions issue with self program updates: https://github.com/Fourdee/DietPi/issues/1260 DietPi-Software | Home Assistant: Resolved an issue with ARMv8 installation, where Python build would fail due to lack of build-essential: https://github.com/Fourdee/DietPi/issues/1255 DietPi-Software | MPD: Corrected various uninstallation issues. DietPi-Software | APT Removal: Resolved an issue in Stretch, where held packages were not being removed: https://github.com/Fourdee/DietPi/issues/475 DietPi-Software | FFMPEG: Resolved inability to install on XU4 Jessie: https://github.com/Fourdee/DietPi/issues/1273 DietPi-Software | Chromium (RPi Stretch): Resolved installation + desktop icon symlink: https://github.com/Fourdee/DietPi/issues/475#issuecomment-350111359 DietPi-Software | Resolved an issue where dietpi permissions were not being set correctly, for symlinked userdata dir. DietPi-Update | Resolved an issue where .update_available file would still exist in no network situations: https://github.com/Fourdee/DietPi/issues/1258 Patch_File | Auto swapfile generation no longer run twice (mostly for pre v150 images): https://github.com/Fourdee/DietPi/issues/1257 **Allo Web Interface v4:** MPD: Native DSD playback support, when "Native" output freq/bit is set in MPD settings page: https://github.com/Fourdee/DietPi/issues/1241 MPD: Default data directory is now "/mnt", this will include all USB drives and network locations. SQUEEZELITE: Added ability to set native DSD output modes. Please note, success of selected output mode is limited to DAC and kernel capabilities. We have verified Combo 384 with u32le output mode on Sparky SBC + USB Bridge: https://github.com/Fourdee/DietPi/issues/1237#issuecomment-348241209 O!MPD: Updated to 1.03. Please make sure to update your library (Settings > Update), to rescan the new "/mnt" location which includes all networked and USB drives. Depending on your additional storage setup, the rescan may take 5-30 minutes. RPi Image: Has been updated to Debian Stretch. This offers peformance improvements in the web interface, and newer ALSA libs. Previous installations are still supported. To upgrade, please write the new image. Upgrading to Stretch is not a requirement: http://dietpi.com/phpbb/viewtopic.php?f=8&t=2317&p=8869#p8869 Sparky SBC: We have remove the WiFi Hotspot installation by default, this is to avoid majority users having to remove this software title, before WiFi can be configured via terminal access. To reinstall this software, please connect the WiFi dongle, then run "dietpi-software install 60" via terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.